fix: removes listeners when app is reloaded on ios #1878
+36
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Bug:
https://drive.google.com/file/d/1xryp5XAyJEfz7ZogrS5fQPK-mALf5Iyh/view?usp=drive_link
Fix:
https://drive.google.com/file/d/1Uz_lrnhXHSs0S4vgp9FP_9oXBKady-wg/view?usp=drive_link
Details
Motivation
When doing a reload on the terminal or devtools window, previously any added listeners would just linger so for each reload you would seen an extra log.
Manual testing
Update OSDemo to have:
Run bun run ios in the example project.
Send a test notification to some test subscription.
Click on the react-native terminal.
Should see 1 log per notification.
I also tested w/ additional data (refresh_messages like in issue report). Prevent default should work.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is