-
Notifications
You must be signed in to change notification settings - Fork 11
Feat/v2/autofill #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/v2/autofill #36
Conversation
When no node is focused, we fallback (only allow) autofill for the form type of the first node in the result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements autofill functionality for the KeyGo application. The main purpose is to introduce a comprehensive autofill service that can provide suggestions for password fields across different applications and browsers while integrating with the existing vault system.
- Adds new autofill service infrastructure with support for inline suggestions and menu datasets
- Refactors core domain models to move from a combined domain structure to separate core modules (
core/itemandcore/util) - Updates dependency versions including Android compilation SDK to 36 and various library versions
Reviewed Changes
Copilot reviewed 222 out of 223 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| settings.gradle.kts | Adds new core modules (item and util) to the build |
| gradle/libs.versions.toml | Updates SDK versions and adds new dependencies for autofill functionality |
| core/util/* | New utility module with domain resolver functionality |
| core/item/* | New item domain module with vault item models and repositories |
| app/src/main/kotlin/de/davis/keygo/autofill/* | Complete autofill service implementation with presentation layer |
| app/src/main/res/* | New autofill service configuration and UI resources |
Comments suppressed due to low confidence (1)
core/util/src/test/kotlin/de/davis/keygo/core/util/data/resolver/OkHttpRegistrableDomainResolverTest.kt:1
- This line uses the
domainparameter instead of the processedhostOrNullvariable, which could bypass the email domain extraction logic implemented in lines 12-16.
package de.davis.keygo.core.util.data.resolver
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
core/item/src/main/kotlin/de/davis/keygo/core/item/di/CoreItemModule.kt
Outdated
Show resolved
Hide resolved
automation-processor/src/main/kotlin/de/davis/keygo/automation/processor/handler/ItemHandler.kt
Show resolved
Hide resolved
automation-processor/src/main/kotlin/de/davis/keygo/automation/processor/handler/ItemHandler.kt
Show resolved
Hide resolved
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
app/src/main/kotlin/de/davis/keygo/autofill/presentation/model/RequestData.kt
Show resolved
Hide resolved
e4d1881 to
6dd90e4
Compare
No description provided.