Skip to content

OT-ContinuousAudio | Audio is converted to a sound file and sent through a websocket in a fixed time frame #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dendenso wants to merge 3 commits into
base: master
Choose a base branch
from
Open

OT-ContinuousAudio | Audio is converted to a sound file and sent through a websocket in a fixed time frame #52

dendenso wants to merge 3 commits into from

Conversation

@dendenso
Copy link

@dendenso dendenso commented Aug 9, 2020 •
edited
Loading

What I Did:

  • Introduced stopwatch library
  • Created bool _recording var and Stopwatch stopwatch object
  • Compressed methods by splitting the contents and housing them in new ones
  • Introduced a while loop for the recorder function
  • Changed logic values
  • Moved DateTime getExportedTime() above @OverRide
  • Created delay Future and forced break for delay
  • To break out of endless loop
  • Data is being sent roughly within 4-5 seconds periodically after initiation of recorder function

How To Test:

  • Required: Zookeeper, Kafka, Spring-boot, port-forwarding with UserService and SessionHandler running. (additionally used docker compose in windows powershell.
  • Obtain an emulator or mobile device
  • Run recorder.dart
  • Press the microphone icon.

freeze

  • The timer has been configured to the point where it resets at 60 and the timer has been set to record up to 99 hours.

recentOTCONT

  • Press the stop icon to reset the recording

@dendenso dendenso linked an issue Aug 9, 2020 that may be closed by this pull request
OT-ContinuouslyRecordAudio (5) #39
Open
@dendenso dendenso changed the title OT-ContinuousAudio | Audio is converted to a sound file and sent through a websocket in a variable time frame OT-ContinuousAudio | Audio is converted to a sound file and sent through a websocket in a fixed time frame Aug 9, 2020
tonynguyen98
tonynguyen98 reviewed Aug 9, 2020
View reviewed changes
Copy link
Collaborator

@tonynguyen98 tonynguyen98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one change... I haven't tested it yet

lib/components/recordingSession/recorder.dart
class _RecorderState extends State<Recorder> {
bool _isRecording = false;
bool _recording = false;
Stopwatch stopwatch = new Stopwatch();
Copy link
Collaborator

@tonynguyen98 tonynguyen98 Aug 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the new keyword

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonynguyen98 tonynguyen98 tonynguyen98 left review comments

@frlzjosh frlzjosh Awaiting requested review from frlzjosh

@steve545 steve545 Awaiting requested review from steve545

@txt020 txt020 Awaiting requested review from txt020

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OT-ContinuouslyRecordAudio (5)

3 participants

@dendenso @tonynguyen98