Skip to content

Conversation

@schofr2
Copy link

@schofr2 schofr2 commented Aug 13, 2025

Description

This change is a new feature. it is a function for carrying out left joins where there are many nulls in the left hand side dataset.
It has not been extensively tested - this will need to be done if incorporated - I'm happy to change this pull request to merge into a feature branch on your side if you wish to develop this further.

Checklist:

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation (docstrings)

Peer review

no peer review has been done.

adds in a function for carrying out left joins where there are many nulls in the dataset
@schofr2 schofr2 requested a review from dombean as a code owner August 13, 2025 14:34
@dombean
Copy link
Member

dombean commented Aug 21, 2025

Thanks for the contribution! A few requests to align with project standards:

  • Thanks for adding type hints to the function signature and docstring.
    • Could you please remove type hints from the Parameters section of the docstring to reduce duplication -- they’re already present in the signature. See: Function House Style
  • Could you add unit tests following our house style? Guide here: Unit Test House Style
  • Please add an Examples section to the docstring to illustrate usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants