Skip to content

Conversation

@jwestw
Copy link
Contributor

@jwestw jwestw commented Jan 14, 2025

Description

Please include a summary of the changes.
  • What is this change?
  • Is this a bug fix or a feature and does it break any existing functionality?
  • How has it been tested?

This pr introduces....

Type of change

You can delete options that are not relevant.

  • Bug fix - non-breaking change
  • New feature - non-breaking change
  • Breaking change - backwards incompatible change, changes expected behaviour
  • Non-user facing change, structural change, dev functionality, docs ...

Checklist:

  • I have performed a self-review of my own code.
  • I have commented my code appropriately, focusing on explaining my design decisions (explain why, not how).
  • I have made corresponding changes to the documentation (comments, docstring, etc.. )
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have updated the change log.

Peer review

Any new code includes all the following:

  • Documentation: docstrings, comments have been added/ updated.
  • Style guidelines: New code conforms to the project's contribution guidelines.
  • Functionality: The code works as expected, handles expected edge cases and exceptions are handled appropriately.
  • Complexity: The code is not overly complex, logic has been split into appropriately sized functions, etc..
  • Test coverage: Unit tests cover essential functions for a reasonable range of inputs and conditions. Added and existing tests pass on my machine.

Review comments

Suggestions should be tailored to the code that you are reviewing. Provide context.
Be critical and clear, but not mean. Ask questions and set actions.

These might include:
  • bugs that need fixing (does it work as expected? and does it work with other code
    that it is likely to interact with?)
  • alternative methods (could it be written more efficiently or with more clarity?)
  • documentation improvements (does the documentation reflect how the code actually works?)
  • additional tests that should be implemented
    • Do the tests effectively assure that it
      works correctly? Are there additional edge cases/ negative tests to be considered?
  • code style improvements (could the code be written more clearly?)

Further reading: code review best practices

jordantgh and others added 6 commits January 9, 2025 13:40
* Improvement: Add paginator to handle large S3 buckets

* Chore: Update changelog

* Fix: Add back file list return

* Test: Add test for multi-page s3 file lists

- Checks that buckets w/ >1000 objects are correctly enumerated

* Chore: Update changelog w/ testing changes
* Include link to easypipelinerun

* Update CHANGELOG.md

---------

Co-authored-by: dombean <46692370+dombean@users.noreply.github.com>
@jwestw jwestw changed the base branch from main to create-validators January 15, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants