Skip to content

Conversation

@TotalDwarf03
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

What

Following the repository refactor, logic for figuring out which teams had copilot data became incorrect. This caused copilot_teams.json to record teams with no copilot data.

To fix this, the logic has been updated so that the lambda checks if the json response from the GitHub API is empty in addition to its original checks.

This PR also includes some minor logging improvements to reduce noise in CloudWatch.

This has been completed in a pair with @smstone0.

Testing

Have any new tests been added as part of this issue? If not, try to explain why test coverage is not needed here.

  • Yes
  • No
    Please write a brief description of why test coverage is not necessary here.
  • Not as part of this ticket. (Could be done at a later point)

Documentation

Has any new documentation been written as part of this issue? We should try to keep documentation up to date
as new code is added, rather than leaving it for the future.

  • Yes
  • No
    Please write a brief description of why documentation is not necessary here.
  • Not as part of this ticket. (Could be done at a later point)

Related issues

KEH-1236 (Jira)

How to review

  • Pull down, setup and run the lambda locally on sdp-dev.
  • Once the lambda has run, verify that copilot_teams.json in S3 is correct (should have around 20~ teams).

@TotalDwarf03 TotalDwarf03 self-assigned this Aug 12, 2025
@TotalDwarf03 TotalDwarf03 requested a review from a team August 12, 2025 15:21
@TotalDwarf03 TotalDwarf03 merged this pull request into main Aug 13, 2025
4 checks passed
@TotalDwarf03 TotalDwarf03 deleted the copilot_teams_bug branch August 13, 2025 12:13
TotalDwarf03 added a commit that referenced this pull request Aug 22, 2025
KEH-1236 | Bug Fix: copilot_team.json logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants