Keh 735 add team info #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Would you be able to merge master into this branch @mwirikia so that the data_logger is using the most up to date version as the format of copilot_teams changed to enable KEH-1122? This is referring to the lambda_data_logger/main.py line 68. Thank you 😃 |
Contributor
TotalDwarf03
left a comment
TotalDwarf03
left a comment
There was a problem hiding this comment.
Needs some changes with logging the team data. The format is fine, but it needs to add to the data already in S3 (if the file exists)
TotalDwarf03
approved these changes
Jul 22, 2025
Contributor
TotalDwarf03
left a comment
TotalDwarf03
left a comment
There was a problem hiding this comment.
Looks good. Works as expected 👍
sebtheo
approved these changes
Jul 23, 2025
Contributor
|
@mwirikia there were still comments in the previous review that haven't been resolved yet |
TotalDwarf03
pushed a commit
that referenced
this pull request
Aug 22, 2025
* Update to remove nan rows in the dataset * Add functionality to get team history from the Github API * add documentation of the team historic metrics * add support for query params - since * update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
What
Functionality to get teams history saved as json.
{ "team" : team_name, "data" : list of daily Copilot usage metrics }Testing
Have any new tests been added as part of this issue? If not, try to explain why test coverage is not needed here.
Please write a brief description of why test coverage is not necessary here.
Documentation
Has any new documentation been written as part of this issue? We should try to keep documentation up to date
as new code is added, rather than leaving it for the future.
Please write a brief description of why documentation is not necessary here.
Related issues
Provide links to any related issues.
How to review
Describe the steps required to test the changes.