KEH-1155 - Record more in copilot_teams.json #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TotalDwarf03
approved these changes
Jul 10, 2025
Contributor
TotalDwarf03
left a comment
TotalDwarf03
left a comment
There was a problem hiding this comment.
Minor change, approving in advance
7 tasks
TotalDwarf03
pushed a commit
that referenced
this pull request
Aug 22, 2025
* update copilot_teams * update hashicorp/aws provider * use .get()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
What
Changed how the copilot_teams is recorded. On the digital landscape, for the KEH-1122 when a user is in an admin team, we then fetch the copilot_teams.json as this is a list of valid teams (5< active copilot licenses) and then we display those on the frontend. This was just a list before and so it didn't have the description of the team, meaning we'd have to make a request for each team to get its info (theres 10+ valid teams currently) so it the requests get a bit much.
FROM:
["test"]TO:
[ { "name": "test", "slug": "test", "description": "Used by https://github.com/ONSdigital/test", "url": "https://github.com/orgs/ONSdigital/teams/test" }, { ... } ]Testing
Have any new tests been added as part of this issue? If not, try to explain why test coverage is not needed here.
Please write a brief description of why test coverage is not necessary here.
Documentation
No. No mention of copilot_teams in the
docs(mkdocs) folder.How to review
Follow steps in
/lambda_data_logger/README.md