Skip to content

Conversation

@TotalDwarf03
Copy link
Contributor

Changes involve replacing the search bar with a populated dropdown of teams with data from S3.

Dashboard Changes:

  • UI is now a selectbox instead of textbox.
  • Method to get teams from S3.
  • The Method is cached so that it only updates once per day.

Lambda Changes:

  • Lambda now collects a list of teams with CoPilot Usage Data from the GitHub API.
  • This list is stored in S3 as copilot_teams.json.
  • The functionality was moved to the Lambda to reduce wait times in the frontend (200 teams in GH -> 200 API Calls).

@TotalDwarf03 TotalDwarf03 requested a review from a team December 4, 2024 14:45
Copy link
Contributor

@sebtheo sebtheo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments that are minor. I'll approve though. Change them if you think it's needed, if not then no worries :)

Comment on lines 136 to 146
Copy link
Contributor

@sebtheo sebtheo Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be split into a helper function instead of having a nested loop?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@delterr delterr self-requested a review December 5, 2024 14:22
Copy link
Contributor

@delterr delterr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@TotalDwarf03 TotalDwarf03 requested a review from a team December 6, 2024 10:30
Copy link
Contributor

@sebtheo sebtheo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@TotalDwarf03 TotalDwarf03 merged this pull request into master Dec 6, 2024
4 checks passed
@TotalDwarf03 TotalDwarf03 deleted the team_selection_dropdown branch December 6, 2024 11:04
TotalDwarf03 added a commit that referenced this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants