drm: sun4i: hdmi: Fix oops when disabling output #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the display does not indicate audio support in the EDID, hdmi->hdmi_audio will be NULL. In this case, we avoid setting up audio output, however we were still attempting to tear it down on disable. This could lead to a null pointer exception when disabling the output. Fix the issue by using the same check on tear down as we do on create. Signed-off-by: Mikel Rychliski <mikel@mikelr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the display does not indicate audio support in the EDID, hdmi->hdmi_audio will be NULL. In this case, we avoid setting up audio output, however we were still attempting to tear it down on disable.
This could lead to a null pointer exception when disabling the output.
Fix the issue by using the same check on tear down as we do on create.