[19.0][MIG] server_environment: Migration to 19.0 #247
Conversation
(lp:c2c-addons/6.1 rev 11)
(lp:c2c-addons/6.1 rev 11.1.4)
(lp:c2c-addons/6.1 rev 28.1.1)
…t is the blessed target. (lp:c2c-addons/6.1 rev 40.2.1)
(lp:c2c-addons/6.1 rev 45.1.4)
…TK client, because for 6.1 the web client is the blessed target. (lp:c2c-addons/6.1 rev 116)
This fixes OCA/server-tools#125 because in some Ubuntu systems lsb_release outputs to stderr as well as stdout. This message will be printed to console, not logged nor shown among server infomation. That way the message is lost and only pollutes unit tests output.
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
nice with static files
* [IMP] load server environment options from odoo rcfile This allows delivering the code with default configuration options for all environments in the server_environment_file module, but letting the administrator override some configuration entries in the regular odoo configuration file. * server_environment_file: update README
To trigger rebuild following change in setup.py
|
/ocabot migration server_environment |
sbidoul
left a comment
sbidoul
left a comment
There was a problem hiding this comment.
Looks good to me.
I'm still slightly annoyed with the monkey patch. As we can't get rid of it, I wonder if it's not the right time to remove the server.config model and move it to another module. It is only used for display. I don't know if many people view the server config through that UI. I personally don't and I always worried about the security implications of exposing server environment through Odoo RPC.
sbidoul
dismissed
their stale review
No change strongly requested anymore. A suggestion to remove the UI part, though.
|
This PR has the |
|
@sbidoul @lembregtse , hi guys, thanks for this pr, could we fix it or accepte to deploy as it ? |
|
@simahawk @gurneyalex as I know you are heavy users of server_environment, what do you think about removing the UI part, and eventually moving it to another module if anyone needs it? It is complex, and I often wonder if it's not a security risk. |
|
Hello @sbidoul , thank you for the reminder. We are currently thinking about a better solution. I will do an internal followup of the question. |
|
seems to be done here ? could we merge these 2 PR ? #249 |
|
My preference goes to removing the UI part (and possibly move it to another module if anyone needs it), but that is not a blocker for me. |
|
As this PR blocks a number of other PRs, I propose merging it in the absence of any response to Stéphane's latest proposals, so that the other PRs can be merged/released in turn. |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at b8e50a5. Thanks a lot for contributing to OCA. ❤️ |
20 participants
We still want to improve to create a seperate config section for running_env.