[18.0][MIG] mail_environment_office365: Migration to 18.0 #243
Conversation
Currently translated at 100.0% (1 of 1 strings) Translation: server-env-17.0/server-env-17.0-mail_environment_office365 Translate-URL: https://translation.odoo-community.org/projects/server-env-17-0/server-env-17-0-mail_environment_office365/it/
|
@gurneyalex can you look? It seems good |
| def _server_env_fields(self): | ||
| base_fields = super()._server_env_fields | ||
| office365_fields = { | ||
| "smtp_authentication": {}, |
There was a problem hiding this comment.
We should merge and forward port this instead, IMO:
The smtp_authentication field is not specific to office365.
Is there no other field needed to be set through the environment, for outlook?
Like the microsoft_outlook_access_token or microsoft_outlook_refresh_token ?
There was a problem hiding this comment.
I'm not sure @ivantodorovich
This module is a specific one. It provides a description of the parameters required for the outlook.
If we go with forward port we will need to update the description on mail_environment.
Maybe it's not obvious for everyone in the community.
There was a problem hiding this comment.
What I'm sure of is that the smtp_authentication field is defined in the base mail module, and re-used by microsoft_outlook and google_gmail (and possibly others) -- so making it configurable through environment belongs to mail_environment, not here.
However, I think you need to make other fields configurable through env, that are truly specific to microsoft_outlook, like the ones I suggested above. But to know this you need to test and see if you can fully configure an email server with outlook credentials by playing solely with the environment
|
This PR will be closed in favor for: |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
5 participants
No description provided.