[FIX] server_environment_ir_config_parameter: Don't save values in DB #236
+26
−51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a system parameter doesn't exist on the production environment, the parameter is created with the environment value that is defined on the production system.
When this DB is exported to a local or other environment, where the environment value is NOT defined on the system, the DB uses the one that has been saved in the production DB.
It is totally unnecessary to store them in the DB, because the get_param function always gets them from the environment, when defined.
Also when you define them in a data file with following values:
and the key is defined in the environment that one will also be used to create the system parameter, instead of the one defined in the data file.
There is logic in place that protects server environment defined fields from being updated at all, see #227
There is no need at all to store these values in the DB!
Everything also works fine when the system parameter is not defined at all.
It will not appear in the list view of the system parameters, but is viewable with the "Server Environment" action.