[18.0][ADD] rma_batch_sale_auto_detect #501
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbejaoui
force-pushed
the
18.0-rma_batch_sale_auto_detect-sbj
branch
4 times, most recently
from
f78d7a7 to
d9ba3fb
Compare
marielejeune
reviewed
Nov 3, 2025
| from odoo.addons.rma_sale_auto_detect.tests.common import TestRmaSaleAutoDetectBase | ||
|
|
||
|
|
||
| class TestRmaBatchSaleAutoDetect(TestRmaSaleAutoDetectBase): |
Contributor
There was a problem hiding this comment.
Tests fail, I guess the class must be tagged as post-install
Comment on lines
+13
to
+18
| def _create_rma(self, partner, product, qty, operation): | ||
| rma = super()._create_rma(partner, product, qty, operation) | ||
| rma.batch_id = self.batch |
Contributor
There was a problem hiding this comment.
What happens if you create a RMA batch for partner 1 but you add RMAs for both partner 1 and partner 2 inside this batch?
I've seen there is a compute on partner_id on rma model, to fill it with the partner of the batch. But what if the link is done in the other way: setting the partner on the RMA first, then adding the RMA to the batch?
Contributor
Author
There was a problem hiding this comment.
I will add a constraint to prevent users from mixing rmas from different partners in the same batch
sbejaoui
force-pushed
the
18.0-rma_batch_sale_auto_detect-sbj
branch
4 times, most recently
from
ada04d0 to
0331e1e
Compare
sbejaoui
force-pushed
the
18.0-rma_batch_sale_auto_detect-sbj
branch
3 times, most recently
from
94fb844 to
c6808e3
Compare
This module extends the batch RMA process by adding automatic sale order linking at batch level. It reuses the matching logic provided by the module `rma_sale_auto_detect`, but allows it to be executed on all RMAs contained inside an `rma.batch`. A new batch state **Manual Treatment** is introduced. If at least one RMA in the batch fails to auto-match, the batch is moved to this state, so the user can review and fix the unmatched RMAs manually. refs: OCA#473 [IMP] rma_batch_sale_auto_detect: allow user to select product then so in batch view
sbejaoui
force-pushed
the
18.0-rma_batch_sale_auto_detect-sbj
branch
from
c6808e3 to
641ae3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module extends the batch RMA process by adding automatic sale order linking at batch level. It reuses the matching logic provided by the module
rma_sale_auto_detect, but allows it to be executed on all RMAs contained inside anrma.batch.A new batch state Manual Treatment is introduced. If at least one RMA in the batch fails to auto-match, the batch is moved to this state, so the user can review and fix the unmatched RMAs manually.
refs: #473