Various fixes for building & running on OS X #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the README with instructions to building on OS X. WzToNx: Use standard C++ locale. No longer dies when a string is too long, instead replacing the string with a message telling the user the string is garbage.
Member
|
PR probably needs to be updated in light of e2453f4 |
Copilot AI
added a commit
to ErwinsExpertise/NoLifeStory
that referenced
this pull request
Nov 8, 2025
The issue was platform-specific due to incorrect handling of string conversions and length limits. Applied the comprehensive fix from the original NoLifeDev repository: 1. Changed limit from 0x1ffff to std::numeric_limits<uint16_t>::max() (65535) 2. Return placeholder string instead of throwing exception (graceful degradation) 3. Fixed convert_str() to use correct char16_t conversion instead of wchar_t 4. Added length check in add_string() to prevent downstream issues 5. Changed locale include from <locale> to <clocale> for standard C++ locale 6. Moved length checks to occur after skip() to properly advance file position This matches the fix proven to work on macOS/Linux in the original repository. Co-authored-by: ErwinsExpertise <44278151+ErwinsExpertise@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the README with instructions to building on OS X.
WzToNx:
Use standard C++ locale.
No longer dies when a string is too long, instead replacing the string
with a message telling the user the string is garbage.