feat: add check for starting_frame without external_file in ImageSeries #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add check_image_series_starting_frame_without_external_file to detect when starting_frame is set on an ImageSeries without external_file. The starting_frame attribute is only relevant when using external files, and setting it otherwise indicates a legacy issue from older PyNWB versions. Includes documentation, unit tests, and changelog entry. Closes #235
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #653 +/- ##
==========================================
+ Coverage 77.41% 81.03% +3.62%
==========================================
Files 47 47
Lines 1656 1661 +5
==========================================
+ Hits 1282 1346 +64
+ Misses 374 315 -59
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check_image_series_starting_frame_without_external_file to detect when starting_frame is set on an ImageSeries without external_file. The starting_frame attribute is only relevant when using external files, and setting it otherwise indicates a legacy issue from older PyNWB versions.
Includes documentation, unit tests, and changelog entry.
Closes #235