Implement AWS SDK v2 support #202
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,135 @@ | ||
| /* | ||
| * Copyright 2018 Netflix, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
| package com.netflix.ndbench.plugin.dynamodb; | ||
|
|
||
| import com.amazonaws.ClientConfiguration; | ||
| import com.amazonaws.client.builder.AwsClientBuilder; | ||
| import com.amazonaws.retry.RetryPolicy; | ||
| import com.amazonaws.services.dynamodbv2.model.BatchGetItemResult; | ||
| import com.amazonaws.services.dynamodbv2.model.BatchWriteItemResult; | ||
| import com.amazonaws.services.dynamodbv2.model.GetItemResult; | ||
| import com.amazonaws.services.dynamodbv2.model.PutItemResult; | ||
| import com.google.common.base.Preconditions; | ||
|
|
||
| import com.amazonaws.services.dynamodbv2.model.ReturnConsumedCapacity; | ||
| import com.netflix.ndbench.plugin.dynamodb.configs.DynamoDBConfigurationBase; | ||
| import com.netflix.ndbench.plugin.dynamodb.operations.v1.dynamodb.dataplane.DynamoDBReadBulk; | ||
| import com.netflix.ndbench.plugin.dynamodb.operations.v1.dynamodb.dataplane.DynamoDBReadSingle; | ||
| import com.netflix.ndbench.plugin.dynamodb.operations.v1.dynamodb.dataplane.DynamoDBWriteBulk; | ||
| import com.netflix.ndbench.plugin.dynamodb.operations.v1.dynamodb.dataplane.DynamoDBWriteSingle; | ||
|
|
||
| import org.apache.commons.lang.StringUtils; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import com.amazonaws.auth.AWSCredentialsProvider; | ||
| import com.amazonaws.services.dynamodbv2.AmazonDynamoDB; | ||
| import com.amazonaws.services.dynamodbv2.AmazonDynamoDBClientBuilder; | ||
| import com.netflix.ndbench.api.plugin.DataGenerator; | ||
| import com.netflix.ndbench.api.plugin.NdBenchClient; | ||
|
|
||
| import static com.amazonaws.retry.PredefinedRetryPolicies.DEFAULT_RETRY_CONDITION; | ||
| import static com.amazonaws.retry.PredefinedRetryPolicies.DYNAMODB_DEFAULT_BACKOFF_STRATEGY; | ||
| import static com.amazonaws.retry.PredefinedRetryPolicies.NO_RETRY_POLICY; | ||
|
|
||
| /** | ||
| * This NDBench plugin provides a single key value for AWS DynamoDB. | ||
| * | ||
| * @author ipapapa | ||
| * @author Alexander Patrikalakis | ||
| */ | ||
| public abstract class BaseConfigurationDynamoDBKeyValue<C extends DynamoDBConfigurationBase> extends DynamoDBKeyValueBase<C, | ||
| GetItemResult, BatchGetItemResult, PutItemResult, BatchWriteItemResult, AWSCredentialsProvider> implements NdBenchClient { | ||
| private static final boolean DO_HONOR_MAX_ERROR_RETRY_IN_CLIENT_CONFIG = true; | ||
| private static final Logger logger = LoggerFactory.getLogger(BaseConfigurationDynamoDBKeyValue.class); | ||
|
|
||
| AmazonDynamoDB dynamoDB; | ||
|
|
||
| /** | ||
| * Public constructor to inject credentials and configuration | ||
| * | ||
| * @param awsCredentialsProvider | ||
| * @param configuration | ||
| */ | ||
|
|
||
| public BaseConfigurationDynamoDBKeyValue(AWSCredentialsProvider awsCredentialsProvider, C configuration) { | ||
| super(awsCredentialsProvider, configuration); | ||
| } | ||
|
|
||
| protected void createAndSetDynamoDBClient() { | ||
|
Contributor
Author
There was a problem hiding this comment. add a comment and explain why protected |
||
| AmazonDynamoDBClientBuilder dynamoDbBuilder = AmazonDynamoDBClientBuilder.standard(); | ||
| dynamoDbBuilder.withClientConfiguration(new ClientConfiguration() | ||
| .withMaxConnections(config.getMaxConnections()) | ||
| .withRequestTimeout(config.getMaxRequestTimeout()) //milliseconds | ||
| .withRetryPolicy(config.getMaxRetries() <= 0 ? NO_RETRY_POLICY : new RetryPolicy(DEFAULT_RETRY_CONDITION, | ||
| DYNAMODB_DEFAULT_BACKOFF_STRATEGY, | ||
| config.getMaxRetries(), | ||
| DO_HONOR_MAX_ERROR_RETRY_IN_CLIENT_CONFIG)) | ||
| .withGzip(config.isCompressing())); | ||
| dynamoDbBuilder.withCredentials(awsCredentialsProvider); | ||
| if (StringUtils.isNotEmpty(this.config.getEndpoint())) { | ||
| Preconditions.checkState(StringUtils.isNotEmpty(config.getRegion()), | ||
| "If you set the endpoint you must set the region"); | ||
| dynamoDbBuilder.withEndpointConfiguration( | ||
| new AwsClientBuilder.EndpointConfiguration(config.getEndpoint(), config.getRegion())); | ||
| } | ||
| this.dynamoDB = dynamoDbBuilder.build(); | ||
| } | ||
|
|
||
| protected void instantiateDataPlaneOperations(DataGenerator dataGenerator) { | ||
|
Contributor
Author
There was a problem hiding this comment. add a java doc and explain why protected |
||
| //instantiate operations | ||
| String tableName = config.getTableName(); | ||
| String partitionKeyName = config.getAttributeName(); | ||
| ReturnConsumedCapacity returnConsumedCapacity = ReturnConsumedCapacity.NONE; | ||
| Preconditions.checkState(StringUtils.isNotEmpty(tableName)); | ||
| Preconditions.checkState(StringUtils.isNotEmpty(partitionKeyName)); | ||
|
|
||
| //data plane | ||
| boolean consistentRead = config.consistentRead(); | ||
| this.singleRead = new DynamoDBReadSingle(dataGenerator, dynamoDB, tableName, partitionKeyName, consistentRead, | ||
| returnConsumedCapacity); | ||
| this.bulkRead = new DynamoDBReadBulk(dataGenerator, dynamoDB, tableName, partitionKeyName, consistentRead, | ||
| returnConsumedCapacity); | ||
| this.singleWrite = new DynamoDBWriteSingle(dataGenerator, dynamoDB, tableName, partitionKeyName, | ||
| returnConsumedCapacity); | ||
| this.bulkWrite = new DynamoDBWriteBulk(dataGenerator, dynamoDB, tableName, partitionKeyName, | ||
| returnConsumedCapacity); | ||
| } | ||
|
|
||
| @Override | ||
| public void shutdown() { | ||
| logger.info("DynamoDB shutdown"); | ||
| dynamoDB.shutdown(); | ||
| } | ||
|
|
||
| /* | ||
| * Not needed for this plugin | ||
| * | ||
| * @see com.netflix.ndbench.api.plugin.NdBenchClient#getConnectionInfo() | ||
| */ | ||
| @Override | ||
| public String getConnectionInfo() { | ||
| return String.format("Table Name - %s : Attribute Name - %s : Consistent Read - %b", | ||
| this.config.getTableName(), | ||
| this.config.getAttributeName(), | ||
| this.config.consistentRead()); | ||
| } | ||
|
|
||
| AmazonDynamoDB getDynamoDB() { | ||
| return this.dynamoDB; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whys is this package different from the standard
com.amazonaws?