-
Notifications
You must be signed in to change notification settings - Fork 69
[Nanowallet]: upgrade trezor connect to v9 #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ed2141b
[nanowallet]: fix build problem
AnthonyLaw a8cf497
[nanowallet]: fix dependencies issue
AnthonyLaw c87e370
[nanowallet]: downgrade bitcoinjs-lib dependencies for fix unit test
AnthonyLaw 4c44da1
[nanowallet]: downgrade ledgerhq dependencies to fix ledge login
AnthonyLaw 2997131
[nanowallet]: fix unit test
AnthonyLaw 56b9528
[nanowallet]: add init unit test setup for mock TrezorConnect
AnthonyLaw a6d7f5b
[nanowallet]: upgrade trezor connect to v9
AnthonyLaw f0accfb
[nanowallet]: fixed dependencies issue for loading nem-voting
AnthonyLaw 535669a
[nanowallet]: removed debug log
AnthonyLaw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| // Mock TrezorConnect | ||
| window.TrezorConnect = { | ||
| init: function() {}, | ||
| nemGetAddress: function() {}, | ||
| nemSignTransaction: function() {}, | ||
| cipherKeyValue: function() {} | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,193 @@ | ||
| import Trezor from '../../src/app/modules/trezor/trezor.service'; | ||
| import { TransactionTypes } from 'nem-library'; | ||
|
|
||
| describe('Trezor Service', () => { | ||
| let trezorService; | ||
| let mockNemGetAddress; | ||
| let mockNemSignTransaction; | ||
| let mockCipherKeyValue; | ||
|
|
||
| const TESTNET_NETWORK = -104; | ||
| const TESTNET_ADDRESS = 'TA545ICAVNEUDFUBIHO3CEJBSVIZ7YYHFFX5LQPT'; | ||
| const MOCK_HD_PATH = "m/44'/1'/0'/0'/0'"; | ||
|
|
||
| const createTestAccount = () => ({ | ||
| hdKeypath: MOCK_HD_PATH, | ||
| network: TESTNET_NETWORK | ||
| }); | ||
|
|
||
| const createTrezorSuccessResponse = payload => Promise.resolve({ | ||
| success: true, | ||
| payload | ||
| }); | ||
|
|
||
| const createTrezorErrorResponse = () => Promise.resolve({ | ||
| success: false, | ||
| payload: { | ||
| error: 'Trezor error' | ||
| } | ||
| }); | ||
|
|
||
| const AssertError = done => (error) => { | ||
| expect(error).toBeDefined(); | ||
| done(); | ||
| }; | ||
|
|
||
| beforeEach(() => { | ||
| spyOn(window.TrezorConnect, 'init'); | ||
| mockNemGetAddress = spyOn(window.TrezorConnect, 'nemGetAddress'); | ||
| mockNemSignTransaction = spyOn(window.TrezorConnect, 'nemSignTransaction'); | ||
| mockCipherKeyValue = spyOn(window.TrezorConnect, 'cipherKeyValue'); | ||
|
|
||
| trezorService = new Trezor(); | ||
| }); | ||
|
|
||
| describe('constructor', () => { | ||
| it('initialize TrezorConnect with correct config', () => { | ||
| // Act + Assert: | ||
| expect(window.TrezorConnect.init).toHaveBeenCalledWith({ | ||
| manifest: { | ||
| email: 'maintainers@nem.io', | ||
| appUrl: 'https://www.nem.io', | ||
| }, | ||
| debug: true, | ||
| coreMode: 'popup', | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| describe('createWallet', () => { | ||
| it('create a wallet with primary account', (done) => { | ||
| mockNemGetAddress.and.returnValue( | ||
| createTrezorSuccessResponse({ address: TESTNET_ADDRESS }) | ||
| ); | ||
|
|
||
| trezorService.createWallet(TESTNET_NETWORK) | ||
| .then(result => { | ||
| expect(result).toEqual({ | ||
| name: 'TREZOR', | ||
| accounts: { | ||
| '0': { | ||
| brain: false, | ||
| algo: 'trezor', | ||
| encrypted: '', | ||
| iv: '', | ||
| address: TESTNET_ADDRESS, | ||
| label: 'Primary', | ||
| network: TESTNET_NETWORK, | ||
| child: '', | ||
| hdKeypath: MOCK_HD_PATH | ||
| } | ||
| } | ||
| }); | ||
| done(); | ||
| }); | ||
| }); | ||
|
|
||
| it('rejected when Trezor operation fails', (done) => { | ||
| // Arrange: | ||
| mockNemGetAddress.and.returnValue( | ||
| createTrezorErrorResponse() | ||
| ); | ||
|
|
||
| // Act + Assert: | ||
| trezorService.createWallet(TESTNET_NETWORK) | ||
| .then(() => {}, AssertError(done)); | ||
| }); | ||
| }); | ||
|
|
||
| describe('deriveRemote', () => { | ||
| it('returns derive remote account', (done) => { | ||
| // Arrange: | ||
| const mockPrivateKey = '0000000000000000000000000000000000000000000000000000000000000000'; | ||
| mockCipherKeyValue.and.returnValue( | ||
| createTrezorSuccessResponse({ value: mockPrivateKey }) | ||
| ); | ||
|
|
||
| // Act: | ||
| trezorService.deriveRemote(createTestAccount(), TESTNET_NETWORK) | ||
| .then(result => { | ||
| // Assert: | ||
| expect(result).toEqual({ | ||
| address: 'TBONKWCOWBZYZB2I5JD3LSDBQVBYHB757VN3SKPP', | ||
| privateKey: mockPrivateKey, | ||
| publicKey: '462ee976890916e54fa825d26bdd0235f5eb5b6a143c199ab0ae5ee9328e08ce' | ||
| }); | ||
| done(); | ||
| }); | ||
| }); | ||
|
|
||
| it('rejected when Trezor operation fails', (done) => { | ||
| // Arrange: | ||
| mockCipherKeyValue.and.returnValue( | ||
| createTrezorErrorResponse() | ||
| ); | ||
|
|
||
| // Act + Assert: | ||
| trezorService.deriveRemote(createTestAccount(), TESTNET_NETWORK) | ||
| .then(() => {}, AssertError(done)); | ||
| }); | ||
| }); | ||
|
|
||
| describe('serialize', () => { | ||
| const createTestTransaction = { | ||
| type: TransactionTypes.TRANSFER, | ||
| amount: 100 | ||
| } | ||
|
|
||
| it('returns transaction payload', (done) => { | ||
| // Arrange: | ||
| const mockSignature = 'serialize payload'; | ||
| mockNemSignTransaction.and.returnValue( | ||
| createTrezorSuccessResponse(mockSignature) | ||
| ); | ||
|
|
||
| // Act: | ||
| trezorService.serialize(createTestTransaction, createTestAccount()) | ||
| .then(result => { | ||
| // Assert: | ||
| expect(result).toBe(mockSignature); | ||
| done(); | ||
| }); | ||
| }); | ||
|
|
||
| it('rejected when signing fails', (done) => { | ||
| // Arrange: | ||
| mockNemSignTransaction.and.returnValue( | ||
| createTrezorErrorResponse() | ||
| ); | ||
|
|
||
| // Act + Assert: | ||
| trezorService.serialize(createTestTransaction, createTestAccount()) | ||
| .then(() => {}, AssertError(done)); | ||
| }); | ||
| }); | ||
|
|
||
| describe('showAccount', () => { | ||
| it('returns account address', (done) => { | ||
| // Arrange: | ||
| mockNemGetAddress.and.returnValue( | ||
| createTrezorSuccessResponse({ address: TESTNET_ADDRESS }) | ||
| ); | ||
|
|
||
| // Act: | ||
| trezorService.showAccount(createTestAccount()) | ||
| .then(result => { | ||
| // Assert: | ||
| expect(result).toBe(TESTNET_ADDRESS); | ||
| done(); | ||
| }); | ||
| }); | ||
|
|
||
| it('rejected when showing account fails', (done) => { | ||
| // Arrange: | ||
| mockNemGetAddress.and.returnValue( | ||
| createTrezorErrorResponse() | ||
| ); | ||
|
|
||
| // Act + Assert: | ||
| trezorService.showAccount(createTestAccount()) | ||
| .then(() => {}, AssertError(done)); | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.