Skip to content

Conversation

@skinkie
Copy link
Contributor

@skinkie skinkie commented Mar 18, 2024

Replaces #418

The VDV example fails because the introduced StartPoints and EndPoints do not exist in the file. Should be resolved first.

@nick-knowles mentions several times this is a draft. Some things must be resolved first.

Typo reviews gracefully accepted. If someone feels like fixing the VDV example would be there thing, please do so.

nick-knowles and others added 5 commits March 18, 2024 20:19
Draft to add the Duty  Stretch and other  Driver Duty elements to NeTEx.
See presentation at  https://3.basecamp.com/3256016/buckets/2570434/uploads/5862915177
1) Factors out Time allowances into separate abstract superclasses
2) Adds extensive
23) Adds a new Duty  Stretch Example

Several issues are unresolved as they need discussion  (Assigned/Duty See presentation
@skinkie skinkie added the enhancement non semantic enhacement: technical enhancement, etc. label Mar 18, 2024
@skinkie skinkie self-assigned this Mar 18, 2024
@skinkie skinkie added this to the netex_3.0 milestone Mar 18, 2024
@trurlurl trurlurl added the needs documentation update The NeTEx document needs to be updated label Mar 19, 2024
@ue71603
Copy link
Contributor

ue71603 commented Mar 19, 2024

@skinkie why did you add this to version 3.0? Not to 2.0?

ue71603
ue71603 previously approved these changes Mar 19, 2024
Copy link
Contributor

@ue71603 ue71603 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me

@ue71603 ue71603 requested a review from Ulf9 March 19, 2024 12:51
@ue71603
Copy link
Contributor

ue71603 commented Mar 19, 2024

@trurlurl can you do a deep dive into the structure?

@skinkie
Copy link
Contributor Author

skinkie commented Mar 19, 2024

@skinkie why did you add this to version 3.0? Not to 2.0?

Because it was #418 was also 3.0.

ue71603 and others added 8 commits March 26, 2024 14:53
…rsion.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…rsion.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…rsion.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…rsion.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…ion.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…ion.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…ion.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
ue71603 and others added 13 commits March 26, 2024 14:57
…nt_support.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…nt_support.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…nt_support.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
….xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…nt_version.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…nt_version.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…on.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…ort.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…ion.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…ion.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
@nick-knowles
Copy link
Contributor

Note that Duty stuff is "advisory" and not part of the formal NeTEx standard - we added an unofficial XML implementation mainly to clarify the old TM conceptual model which had never been systematically modularised for implementation.

This is the current UML for DUTY STRECH - Was the error in the implementiontion XML rathe r han the UML?
image

@nick-knowles
Copy link
Contributor

This is the current UML - doe shave a DAY TYPE for DUTY
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement non semantic enhacement: technical enhancement, etc. needs documentation update The NeTEx document needs to be updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants