Skip to content
This repository was archived by the owner on Nov 19, 2025. It is now read-only.

Conversation

@terrykong
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong terrykong added Skip CICD r0.7.0 creates cherry-pick PR after merge (add before Run CICD label) labels Mar 4, 2025
@terrykong terrykong requested a review from ashors1 March 4, 2025 19:30
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 4, 2025
ashors1
ashors1 previously approved these changes Mar 4, 2025
@terrykong terrykong added Run CICD Set + un-set to retrigger (add after r*.*.* labels) Skip CICD and removed Skip CICD Run CICD Set + un-set to retrigger (add after r*.*.* labels) labels Mar 4, 2025
@terrykong terrykong added this pull request to the merge queue Mar 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to invalid changes in the merge commit Mar 4, 2025
@terrykong terrykong added this pull request to the merge queue Mar 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to invalid changes in the merge commit Mar 4, 2025
@terrykong terrykong dismissed ashors1’s stale review March 4, 2025 20:31

The merge-base changed after approval.

@terrykong terrykong requested a review from jgerh March 5, 2025 01:38
Copy link
Collaborator

@jgerh jgerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments on README.md

Line 6
Add definite article "The" and fix capitalization "arXiv"

Line 30
Add period

Line 47
suggest a different heading

Get Started with NeMo-Aligner

Line 48
revise

NeMo-Aligner is included with NeMo containers. To run a NeMo container on a machine with NVIDIA GPUs and drivers installed, use the following command:

Line 52
revise

Once inside the container, you'll find NeMo-Aligner pre-installed. You can locate it, along with NeMo and other tools, in the ```/opt/`` folder.

Line 70
fix capitalization

Future Work

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation r0.7.0 creates cherry-pick PR after merge (add before Run CICD label) Skip CICD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants