Skip to content
This repository was archived by the owner on Nov 19, 2025. It is now read-only.

Conversation

@ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Sep 6, 2024

What does this PR do ?

We use a GH team to manage (and hide) the team of code-owners: https://github.com/orgs/NVIDIA/teams/nemo-aligner-reviewers

This is important: Whereas in GitLab the team members are transparent, here in GitHub is it not. I think this is also desired so it fits our requirements quite well.

I actually don't know if you want CODEOWNERS, it just randomly appeared me that we could do this easily. Feel free to close this PR if you want to keep it more ad-hoc.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the CI label Sep 6, 2024
@ko3n1g ko3n1g requested review from gshennvm and terrykong September 6, 2024 02:00
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g force-pushed the ko3n1g/chore/codeowners branch from f1b84f5 to 37a1e2d Compare September 6, 2024 02:00
@ko3n1g ko3n1g marked this pull request as ready for review September 6, 2024 02:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants