Improve volumetric attenuation accuracy and remove artificial distance limits #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinqAdams
force-pushed
the
fix/volumetric-attenuation-improvements
branch
from
4424f8a to
d1079cb
Compare
…e limits Remove min() clamp in volume_lighting.slangh for physically correct attenuation Use actual hit distances instead of artificially clamped distances Improve plane distance calculation using actual hit positions in volume_composite_helpers.slangh Better handling of rays extending beyond froxel grid maximum distance Add explanatory comments for architectural decisions
BinqAdams
force-pushed
the
fix/volumetric-attenuation-improvements
branch
from
d1079cb to
fdac3da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the accuracy of volumetric attenuation calculations and removes artificial distance limitations for more physically correct rendering.
Changes:
Remove min() clamp in volume_lighting.slangh for physically correct attenuation
Use actual hit distances instead of artificially clamped distances
Improve plane distance calculation using actual hit positions in volume_composite_helpers.slangh
Better handling of rays extending beyond froxel grid maximum distance
Add explanatory comments for architectural decisions
Benefits:
More physically accurate volumetric attenuation
Better visual quality for distant light sources in volumetric scenes
Eliminates inconsistencies between infinite and finite ray handling