Fix spot lights imported from glTF files. #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomeNvidiaGuy
force-pushed
the
main
branch
2 times, most recently
from
f8b0648 to
fe9d7c4
Compare
SomeNvidiaGuy
force-pushed
the
main
branch
2 times, most recently
from
13a7501 to
139343d
Compare
SomeNvidiaGuy
force-pushed
the
main
branch
2 times, most recently
from
bec6b38 to
2d7c4a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spot lights currently only work correctly if they have a non-zero radius. When exported from glTF they always have a radius of
0.0f(non-point shapes are not supported there).This PR adds some code to correctly handle spot lights with zero radius (similar to point lights with zero radius).