Skip to content

Conversation

@redoctopus
Copy link
Collaborator

What does this PR do ?

Ports the Riva Mel Cepstral Distortion - Dynamic Time Warping notebook (nvidia-riva/tutorials#96) to NeMo.

HTML version here for ease of viewing:
https://drive.google.com/file/d/1E7bk95HQXZE_LyCfryr1r9LEKPzm8J9D/view?usp=sharing

Collection: TTS

Changelog

  • Minor changes to ensure the notebook runs both locally and in Colab (tarred the example data, changed the way the audio is displayed)
  • Additional docstrings and function explanations
  • Minor text updates

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
@redoctopus redoctopus requested a review from blisc January 11, 2023 22:53
@github-actions github-actions bot added the TTS label Jan 11, 2023
" Returns:\n",
" mels: Corresponding mel spectrogram.\n",
" \"\"\"\n",
" wav_, _ = librosa.load(filename) # load() returns an (audio data, sample rate) tuple\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to pass sr to librosa otherwise it auto resamples to 22050

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

redoctopus and others added 4 commits January 12, 2023 13:13
Co-authored-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jocelyn <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
@redoctopus redoctopus requested a review from blisc January 13, 2023 19:16
@redoctopus redoctopus merged commit 5b4e97c into main Jan 14, 2023
@redoctopus redoctopus deleted the mcd_dtw_notebook branch January 14, 2023 00:48
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
…VIDIA-NeMo#5778)

* Port and update Riva MCD DTW tutorial to NeMo TTS tutorials

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

* Add audio files for the MCD DTW notebook

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

* Moved MCD DTW examples to tarball, added add'l resources section

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

* Fix wget link for MCD DTW notebook

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

* Rework audio playing

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

* Typo fixes to MCD DTW notebook

Co-authored-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jocelyn <jocelynh@nvidia.com>

* Pass sample rate to librosa load

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn <jocelynh@nvidia.com>
Co-authored-by: Jason <jasoli@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants