New: [AEA-6037] - Introduce Proxygen API for PFP #2207

connoravo-nhs · 2025-12-11T09:39:10Z

Summary

✨ New Feature

Details

Introduce PFP Proxygen API by utilising OAS specification from https://github.com/NHSDigital/prescriptions-for-patients
Build out deployment pipeline to automatically deploy to Apigee
Introduce required change to PFP to work with new proxygen headers

…m-nhs:NHSDigital/prescriptionsforpatients

…ents

Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>

github-actions · 2025-12-11T09:39:19Z

This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket:

AEA-6037

Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>

…patients into AEA-6037

Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>

…ents

Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>

…ents

Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>

connoravo-nhs · 2025-12-19T16:27:00Z

packages/specification/prescriptions-for-patients.yaml

@@ -0,0 +1,448 @@
+# This is an OpenAPI Specification (https://swagger.io/specification/)


Within /specification, only the following has had changes made, versus being copied from https://github.com/NHSDigital/prescriptions-for-patients.

prescriptions-for-patients.yaml

redocly.yaml

package.json

tsconfig.json

connoravo-nhs · 2025-12-19T16:27:05Z

packages/specification/package.json

@@ -0,0 +1,23 @@
+{


Within /specification, only the following has had changes made, versus being copied from https://github.com/NHSDigital/prescriptions-for-patients.

prescriptions-for-patients.yaml

redocly.yaml

package.json

tsconfig.json

connoravo-nhs · 2025-12-19T16:27:10Z

packages/specification/redocly.yaml

@@ -0,0 +1,3 @@
+apis:


Within /specification, only the following has had changes made, versus being copied from https://github.com/NHSDigital/prescriptions-for-patients.

prescriptions-for-patients.yaml

redocly.yaml

package.json

tsconfig.json

connoravo-nhs · 2025-12-19T16:27:18Z

packages/specification/tsconfig.json

@@ -0,0 +1,9 @@
+{


Within /specification, only the following has had changes made, versus being copied from https://github.com/NHSDigital/prescriptions-for-patients.

prescriptions-for-patients.yaml

redocly.yaml

package.json

tsconfig.json

sonarqubecloud · 2025-12-19T16:28:59Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

anthony-nhs · 2025-12-19T16:41:18Z

.github/workflows/release.yml

      TARGET_SERVICE_SEARCH_SERVER: sandbox
+      PROXYGEN_ROLE: ${{ secrets.PROXYGEN_PTL_ROLE }}

  release_prod:


shouldnt you have a DEPLOY_APIGEE: false in here for prod

anthony-nhs · 2025-12-19T16:42:10Z

.github/workflows/release.yml

      PROD_CLOUD_FORMATION_CHECK_VERSION_ROLE: ${{ secrets.PROD_CLOUD_FORMATION_CHECK_VERSION_ROLE }}
      DEV_CLOUD_FORMATION_EXECUTE_LAMBDA_ROLE: ${{ secrets.DEV_CLOUD_FORMATION_EXECUTE_LAMBDA_ROLE }}
-
+      PROXYGEN_ROLE: ${{ secrets.PROXYGEN_PTL_ROLE }}


should be PROXYGEN_PROD_ROLE for INT deployment

anthony-nhs · 2025-12-19T16:43:11Z

.github/workflows/pull_request.yml

-      TARGET_SPINE_SERVER: sandbox
-      TARGET_SERVICE_SEARCH_SERVER: sandbox
+      PROXYGEN_ROLE: ${{ secrets.PROXYGEN_PTL_ROLE }}
+# release_sandbox_code:


can we just deploy it with DEPLOY_APIGEE: false?

also if we do comment it out, should do the same in ci.yml and release.yml

anthony-nhs · 2025-12-19T16:45:30Z

package.json

    "packages/common/testing",
-    "packages/distanceSelling"
+    "packages/distanceSelling",
+    "packages/specification"


this needs adding to .vscode/eps-prescription-status-update-api.code-workspace as well

anthony-nhs · 2025-12-19T16:47:34Z

packages/getMyPrescriptions/src/extractNHSNumber.ts

+export function extractNHSNumberFromHeaders(headers: EventHeaders): string {
+  if (headers["nhs-login-identity-proofing-level"]) {
+    // Proxygen spec will include proofing level header, whereas non-proxygen API will not
+    return validateNHSNumber(headers["nhsd-nhslogin-user"]!)


should check proofing level is P9 as in https://github.com/NHSDigital/prescriptionsforpatients/blob/main/packages/getMyPrescriptions/src/extractNHSNumber.ts#L20

tstephen-nhs and others added 6 commits November 3, 2025 13:05

Chore: devcontainer fail fast, posix equality, force docker gid

712b864

chore: provide docker gid from env

b2ebc80

Merge branches 'aea-0000-devcontainer-docker' and 'main' of github.co…

c330f5c

…m-nhs:NHSDigital/prescriptionsforpatients

Merge branch 'main' of github.com-nhs:NHSDigital/prescriptionsforpati…

60d7d77

…ents

Merge branch 'main' of github.com-nhs:NHSDigital/prescriptionsforpati…

7c85ef3

…ents

WIP - Modify pipeline & include full spec

2ffc014

Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>

Remove specification as TS package

4c10f79

Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>

connoravo-nhs had a problem deploying to dev-pr December 15, 2025 09:33 — with GitHub Actions Failure

connoravo-nhs and others added 2 commits December 15, 2025 11:19

Pipeline kickoff

398771c

Merge branch 'main' into AEA-6037

44ab332

connoravo-nhs had a problem deploying to dev-pr December 15, 2025 11:27 — with GitHub Actions Failure

connoravo-nhs had a problem deploying to dev-pr December 15, 2025 11:32 — with GitHub Actions Failure

connoravo-nhs added 4 commits December 15, 2025 11:37

Pipeline kickoff

519d0c5

Pipeline kickoff

0382173

Merge branch 'AEA-6037' of github.com-nhs:NHSDigital/prescriptionsfor…

590d8f6

…patients into AEA-6037

Pipeline kickoff2

ad0dbf4

connoravo-nhs had a problem deploying to dev-pr December 15, 2025 11:45 — with GitHub Actions Failure

connoravo-nhs added 2 commits December 15, 2025 12:09

NPM run redocly #skip-qc

8af4e50

Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>

Remove unneccessary dependencies

08e1e78

Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>

connoravo-nhs had a problem deploying to dev-pr December 15, 2025 12:22 — with GitHub Actions Failure

Fix build #skip-qc

09df7a0

Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>

connoravo-nhs had a problem deploying to dev-pr December 15, 2025 12:45 — with GitHub Actions Failure

Modify path

b4b3461

Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>

connoravo-nhs had a problem deploying to dev-pr December 15, 2025 14:12 — with GitHub Actions Failure

Both use branch?

6f61460

Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>

connoravo-nhs temporarily deployed to dev December 19, 2025 10:19 — with GitHub Actions Inactive

connoravo-nhs had a problem deploying to dev-pr December 19, 2025 10:19 — with GitHub Actions Failure

Kick off pipeline

1821e3e

connoravo-nhs temporarily deployed to dev December 19, 2025 11:11 — with GitHub Actions Inactive

connoravo-nhs had a problem deploying to dev-pr December 19, 2025 11:11 — with GitHub Actions Failure

Kick off pipeline2

07c3e8b

connoravo-nhs had a problem deploying to dev-pr December 19, 2025 15:25 — with GitHub Actions Failure

connoravo-nhs temporarily deployed to dev December 19, 2025 15:25 — with GitHub Actions Inactive

connoravo-nhs added 3 commits December 19, 2025 15:31

Merge branch 'main' of github.com-nhs:NHSDigital/prescriptionsforpati…

ec0d37f

…ents

Merge branch 'main' into AEA-6037

3888863

fix target environment

f9ecf4b

Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>

connoravo-nhs temporarily deployed to dev December 19, 2025 15:43 — with GitHub Actions Inactive

connoravo-nhs had a problem deploying to dev December 19, 2025 15:43 — with GitHub Actions Failure

connoravo-nhs added 3 commits December 19, 2025 15:50

Remove sandbox environment on PRs

d632fcb

Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>

Merge branch 'main' of github.com-nhs:NHSDigital/prescriptionsforpati…

ea1dfba

…ents

Merge branch 'main' into AEA-6037

55fae2c

connoravo-nhs temporarily deployed to dev December 19, 2025 16:12 — with GitHub Actions Inactive

Set latest regression test version for PFP Proxygen changes

260f597

Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>

connoravo-nhs commented Dec 19, 2025

View reviewed changes

connoravo-nhs temporarily deployed to dev December 19, 2025 16:30 — with GitHub Actions Inactive

anthony-nhs reviewed Dec 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

New: [AEA-6037] - Introduce Proxygen API for PFP #2207

New: [AEA-6037] - Introduce Proxygen API for PFP #2207

connoravo-nhs commented Dec 11, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

connoravo-nhs Dec 19, 2025

Uh oh!

connoravo-nhs Dec 19, 2025

Uh oh!

connoravo-nhs Dec 19, 2025

Uh oh!

connoravo-nhs Dec 19, 2025

Uh oh!

sonarqubecloud bot commented Dec 19, 2025

Uh oh!

anthony-nhs Dec 19, 2025

Uh oh!

anthony-nhs Dec 19, 2025

Uh oh!

anthony-nhs Dec 19, 2025

Uh oh!

anthony-nhs Dec 19, 2025

Uh oh!

anthony-nhs Dec 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,448 @@
		# This is an OpenAPI Specification (https://swagger.io/specification/)

New: [AEA-6037] - Introduce Proxygen API for PFP #2207

Are you sure you want to change the base?

New: [AEA-6037] - Introduce Proxygen API for PFP #2207

Conversation

connoravo-nhs commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details

Uh oh!

github-actions bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Dec 19, 2025

Quality Gate passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

connoravo-nhs commented Dec 11, 2025 •

edited

Loading

github-actions bot commented Dec 11, 2025 •

edited

Loading