generated from nhs-england-tools/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 1
Dtoss 11646 setup container apps container probes #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mrlockstar
merged 1 commit into
main
from
DTOSS-11646-Setup-Container-Apps-container-probes
Dec 9, 2025
Merged
Dtoss 11646 setup container apps container probes #265
mrlockstar
merged 1 commit into
main
from
DTOSS-11646-Setup-Container-Apps-container-probes
Dec 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b934660 to
2fdcd65
Compare
saliceti
reviewed
Dec 4, 2025
saliceti
reviewed
Dec 4, 2025
saliceti
reviewed
Dec 4, 2025
saliceti
reviewed
Dec 4, 2025
saliceti
reviewed
Dec 4, 2025
Contributor
|
Please run terraform-docs when you're done |
saliceti
reviewed
Dec 4, 2025
9713e6d to
ccd8397
Compare
saliceti
reviewed
Dec 9, 2025
saliceti
reviewed
Dec 9, 2025
saliceti
reviewed
Dec 9, 2025
ffc3347 to
9b01b7d
Compare
saliceti
reviewed
Dec 9, 2025
9b01b7d to
7e92d3b
Compare
saliceti
reviewed
Dec 9, 2025
saliceti
reviewed
Dec 9, 2025
7e92d3b to
81a96ce
Compare
We need to configure a container probe (liveness/readiness & startup) for our Azure Container Apps deployment. By default, the web application should only have a heath probe if the variable probe_path is set. If probe_path is null then it's disabled. Please note that we cannot do this for the Postgres DB container as there is no Django / restful interface to implement. Also update the terradocs on the container app module and update the README.md for instructions on how to deploy probes from the root module.
81a96ce to
d26e08b
Compare
saliceti
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to configure a container probe (liveness/readiness) for our Azure Container Apps deployment.
By default, the web application should only have a heath probe if the variable probe_path is set.
If probe_path is null then it's disabled.
Please note that we cannot do this for the Postgres DB container as there is no Django / restful interface to implement.
Please look for container app manbrs-web-pr-801 for evidence. Note I have observed the container for 10 plus minutes and have been able to log in and off the container without it crashing.
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.