New hardware and firmware for board V2 #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopolise
requested changes
Nov 14, 2025
Contributor
christopolise
left a comment
christopolise
left a comment
There was a problem hiding this comment.
This is a big PR, and almost everything is great. There are some bug fixes linked and also a request for some quick comments that will help with documenting later
| } | ||
| } | ||
|
|
||
| // void setup() { |
Contributor
There was a problem hiding this comment.
Is there a reason we are including this commented code? Can we delete it or is it documenting something?
| commandBuffer[i + 2] = 1 | ||
| for i in range(10): | ||
| sock.sendto(commandSerializer.pack(*commandBuffer), ("172.0.0.3", 1883)) | ||
| # for index, value in enumerate(commandBuffer[2:].reverse()): |
Contributor
There was a problem hiding this comment.
Does this need to stay as a documenting feature or can it be removed?
| import struct | ||
| import time | ||
|
|
||
| sock = socket.socket(socket.AF_INET, socket.SOCK_DGRAM) |
Contributor
There was a problem hiding this comment.
Can we get some quick comments on this file?
| @@ -0,0 +1,366 @@ | |||
| #include <Arduino.h> | |||
Contributor
There was a problem hiding this comment.
Can we get some comments on this file?
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.