Skip to content

Conversation

@zulquer
Copy link
Collaborator

@zulquer zulquer commented Dec 2, 2025

This pull request includes minor improvements to code documentation and configuration. The most important changes are:

Documentation improvements:

  • Added a docstring to the __init__ method of the MockItem class in tests/multisafepay/unit/api/base/listings/test_unit_listing.py to clarify its purpose.

Configuration updates:

  • Removed D104 and D107 from the ignore list in the extend-safe-fixes section of pyproject.toml, potentially enabling stricter docstring checks for missing docstrings in public packages and methods.

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.69%. Comparing base (ffdfce0) to head (0b9a069).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   90.69%   90.69%           
=======================================
  Files         143      143           
  Lines        2471     2471           
=======================================
  Hits         2241     2241           
  Misses        230      230           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves code documentation standards by removing docstring rule exceptions and adding documentation where previously ignored. The changes enable stricter enforcement of docstring requirements for public packages and __init__ methods.

Key Changes:

  • Enabled stricter docstring checks by removing D104 and D107 exceptions
  • Added compliant __init__ docstring to MockItem test class

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/multisafepay/unit/api/base/listings/test_unit_listing.py Added docstring to MockItem.init method to comply with newly enabled D107 rule
pyproject.toml Removed D104 and D107 from ignore list to enforce docstring requirements for public packages and init methods

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@danielcivit danielcivit merged commit 97218f5 into master Dec 3, 2025
6 checks passed
@danielcivit danielcivit deleted the PTHMINT-88 branch December 3, 2025 10:06
danielcivit pushed a commit that referenced this pull request Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants