Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions standard_open_inflation_package/direct_request_interceptor.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,14 @@ async def _handle_captured_response(self, handlers: List[Handler], response, req
url=response.url,
error=e
))
current_time = time.time()
for handler in handlers:
self.handler_errors[handler.slug] = HandlerSearchFailed(
rejected_responses=self.rejected_responses,
duration=current_time - self.start_time,
handler_slug=handler.slug,
)
self._check_completion()

def _handle_rejected_response(self, response, request, response_time: float):
"""Обрабатывает отклоненный response"""
Expand Down
20 changes: 19 additions & 1 deletion tests/api/interceptor_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
run_direct_fetch_test,
run_page_resource_intercept_test,
run_no_intercept_test,
assert_success_result,
assert_success_result,
assert_failed_result,
assert_html_content,
api_session,
DEFAULT_TIMEOUT,
Expand Down Expand Up @@ -202,3 +203,20 @@ def check_audio_content(response):
additional_checks=check_audio_content,
min_resources=1
)


@pytest.mark.asyncio
async def test_handler_error_marks_failed(monkeypatch):
"""Ensure handler errors are reported as failures."""
import standard_open_inflation_package.direct_request_interceptor as interceptor

def raise_error(*args, **kwargs):
raise RuntimeError("boom")

monkeypatch.setattr(interceptor, "parse_response_data", raise_error)

async with api_session(DEFAULT_TIMEOUT) as api:
results = await api.new_direct_fetch(CHECK_HTML_PAGE, handlers=Handler.MAIN())

assert len(results) == 1
assert_failed_result(results[0], min_rejected=0)
Loading