Skip to content

small planar bug fix and vignette pedantry #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tildejustin merged 3 commits into from
Jul 2, 2025
Merged

small planar bug fix and vignette pedantry #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c744ecb
reset nv fog mode to planar if it ever gets set to radial
tildejustin Mar 23, 2025
b164989
don't allow enabling vignette on fast
tildejustin Mar 23, 2025
c14da18
update action
tildejustin Mar 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,7 @@ jobs:
- name: checkout repository
uses: actions/checkout@v4
- name: validate gradle wrapper
uses: gradle/wrapper-validation-action@v1
- name: setup java
uses: actions/setup-java@v4
with:
distribution: "temurin"
java-version: 21
uses: gradle/actions/wrapper-validation@v4
- name: build
run: |
chmod +x ./gradlew
Expand Down
11 changes: 6 additions & 5 deletions src/main/java/me/jellysquid/mods/sodium/mixin/features/options/MixinBackgroundRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
package me.jellysquid.mods.sodium.mixin.features.options;

import com.mojang.blaze3d.systems.RenderSystem;
import com.mojang.blaze3d.platform.GlStateManager;
import me.jellysquid.mods.sodium.client.SodiumClientMod;
import net.minecraft.client.render.BackgroundRenderer;
import org.lwjgl.opengl.GL;
import org.lwjgl.opengl.NVFogDistance;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Redirect;
Expand All @@ -11,10 +13,9 @@
public abstract class MixinBackgroundRenderer {
@Redirect(method = "applyFog", at = @At(value = "INVOKE", target = "Lcom/mojang/blaze3d/systems/RenderSystem;setupNvFogDistance()V"))
private static void redirectSetupNvFogDistance() {
if (SodiumClientMod.options().speedrun.usePlanarFog) {
return;
} else {
RenderSystem.setupNvFogDistance();
if (GL.getCapabilities().GL_NV_fog_distance) {
int fogType = SodiumClientMod.options().speedrun.usePlanarFog ? NVFogDistance.GL_EYE_PLANE_ABSOLUTE_NV : NVFogDistance.GL_EYE_RADIAL_NV;
GlStateManager.fogi(NVFogDistance.GL_FOG_DISTANCE_MODE_NV, fogType);
}
}
}
8 changes: 4 additions & 4 deletions src/main/java/me/jellysquid/mods/sodium/mixin/features/options/MixinInGameHud.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
package me.jellysquid.mods.sodium.mixin.features.options;

import com.llamalad7.mixinextras.injector.ModifyExpressionValue;
import me.jellysquid.mods.sodium.client.SodiumClientMod;
import net.minecraft.client.gui.hud.InGameHud;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Redirect;

@Mixin(InGameHud.class)
public class MixinInGameHud {
@Redirect(method = "render", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/MinecraftClient;isFancyGraphicsOrBetter()Z"))
private boolean redirectFancyGraphicsVignette() {
return SodiumClientMod.options().quality.enableVignette;
@ModifyExpressionValue(method = "render", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/MinecraftClient;isFancyGraphicsOrBetter()Z"))
private boolean redirectFancyGraphicsVignette(boolean original) {
return original && SodiumClientMod.options().quality.enableVignette;
}
}