-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add support for translations #6029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Wide-Cat
wants to merge
48
commits into
master
Choose a base branch
from
translations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganised the translation files and keys. Lots of work still to be done to change our hardcoded strings into translatable ones. We should no longer be susceptible to detection by servers using the translation exploit.
…d by the translation system
Translations will be automatically updated when the user changes their language.
Adds a label in the bottom right corner of the modules screen that can be clicked on to give translation information.
This includes command exceptions and info/warning/error messages. Still more to be done for commands. This is a bit of a rough draft, if you have any ideas on how better to name or format this, open an issue or message me.
# Conflicts: # src/main/java/meteordevelopment/meteorclient/commands/commands/WaspCommand.java # src/main/java/meteordevelopment/meteorclient/gui/screens/ModulesScreen.java # src/main/java/meteordevelopment/meteorclient/gui/widgets/WWidget.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer
We are not accepting translations right now as this is still a work in progress - only after we finalise everything and merge this into the main branch we will start accepting translations via pull requests or the web page (see below).
Description
Implements a translation system to support different languages in all relevant places. We are using our own custom translation system to prevent meteor being detected by servers via the translation exploit.
We have set up a web page at https://translations.meteordev.org where users can create an account and submit translations - we will periodically merge this into the master branch. It would be useful to set up some incentives for translating, e.g. after translating 25 keys they can be added to
meteor.lang.translatorsor after 100 keys they get access to a translator cape.Information for developers
This will break every addon that currently exists and will not only require addon authors update their existing addons, but places more to do on the authors when creating new features in the first place, as meteor will now expect user facing strings like names and descriptions to be placed in the language file.
Todo fill this out, maybe create a Translations.md file.
kebab-casenaming as with meteorThings to do
ChatUtilsto accept translatableTextcomponents - we can't just pass in a translatedStringsince they do not update with the language.Related issues
closes #5282
closes #5864
closes #2141