-
Notifications
You must be signed in to change notification settings - Fork 639
feat: Support more chains when simulating Ethereum provider #3789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bbb9463
feat: Support more chains when simulating Ethereum provider
FrederikBolding 3f14e08
Catch errors
FrederikBolding 3dbdf7c
Update Ethers snap checksum
FrederikBolding 48af24a
Sync Ethers version
FrederikBolding cb46b81
Fix test
FrederikBolding 293b406
Add additional tests
FrederikBolding bccc62f
Tweak assertion
FrederikBolding e482115
Reflect chain ID change in other RPC methods and remove getProviderState
FrederikBolding c6b720e
Fix build
FrederikBolding 2804ed6
Use hexToBigInt
FrederikBolding bbcb0f4
Tweak mock
FrederikBolding 37cc50b
Include cause in internal errors
FrederikBolding File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { getSetCurrentChainImplementation } from './chain'; | ||
| import { createStore } from '../../store'; | ||
| import { getMockOptions } from '../../test-utils'; | ||
|
|
||
| describe('getSetCurrentChainImplementation', () => { | ||
| it('returns the implementation of the `setCurrentChain` hook', async () => { | ||
| const { store, runSaga } = createStore(getMockOptions()); | ||
|
|
||
| expect(store.getState().chain.chainId).toBe('0x1'); | ||
|
|
||
| const fn = getSetCurrentChainImplementation(runSaga); | ||
|
|
||
| expect(fn('0x2')).toBeNull(); | ||
|
|
||
| expect(store.getState().chain.chainId).toBe('0x2'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import type { Hex } from '@metamask/utils'; | ||
| import type { SagaIterator } from 'redux-saga'; | ||
| import { put } from 'redux-saga/effects'; | ||
|
|
||
| import { setChain } from '../../store'; | ||
| import type { RunSagaFunction } from '../../store'; | ||
|
|
||
| /** | ||
| * Set the current chain ID in state. | ||
| * | ||
| * @param chainId - The chain ID. | ||
| * @yields Puts the chain ID in the store. | ||
| * @returns `null`. | ||
| */ | ||
| function* setCurrentChainImplementation(chainId: Hex): SagaIterator { | ||
| yield put(setChain(chainId)); | ||
| return null; | ||
| } | ||
|
|
||
| /** | ||
| * Get a method that can be used to set the current chain. | ||
| * | ||
| * @param runSaga - A function to run a saga outside the usual Redux flow. | ||
| * @returns A method that can be used to set the current chain. | ||
| */ | ||
| export function getSetCurrentChainImplementation(runSaga: RunSagaFunction) { | ||
| return (...args: Parameters<typeof setCurrentChainImplementation>) => { | ||
| return runSaga(setCurrentChainImplementation, ...args).result(); | ||
| }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 0 additions & 33 deletions
33
packages/snaps-simulation/src/middleware/internal-methods/provider-state.test.ts
This file was deleted.
Oops, something went wrong.
35 changes: 0 additions & 35 deletions
35
packages/snaps-simulation/src/middleware/internal-methods/provider-state.ts
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getProviderStateis no longer called by Snaps, should be dead code.