Add faceted type-ahead search capability to CSET web interface #1713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfrost-mo
force-pushed
the
MSc_ui_improvements
branch
from
dcb8464 to
281677c
Compare
Contributor
|
|
jfrost-mo
changed the title
jfrost-mo
changed the title
Member
Author
|
BUG: White space should be \s, rather than just "\t ". |
This was referenced Oct 28, 2025
Open
jfrost-mo
force-pushed
the
MSc_ui_improvements
branch
3 times, most recently
from
d6b77ca to
06d6e99
Compare
Additionally included is a conversion to JSON Lines (In theory it should be more efficient, but in practice we still load the whole string first, so I may revert. At least it looks nicer in the index file.) Finally there are also some experiments with the UI for facets, ahead of getting feedback from the user interviews. The framework is there for facet-based searching, but the current implementation of search is very basic, only doing exact substring matching. Additional functionality should be added to the test function constructed in parse_query.
The lexer is complete, but the parser still needs to be written, then it all needs to be ported to JavaScript. Some example queries are defined in "querys".
I think it should now be complete, though I haven't extensively tested it yet. GitHub Copilot was used in this commit. It did an initial implementation of parse_grouped_expression, and helped debug collapse_conditions, where I had sliced from the start of the conditions list, rather than from the current index.
This avoids splitting literals with and/or as substrings, such as [and]roid or h[or]se. This issue and fix was suggested by GitHub Copilot.
This issue was identified by GitHub Copilot
The main behaviour changes are that NOT is now a separate combiner from the ! operator, and that explicit and implicit ANDs now have the same precedence.
I'm going to park further parser work for now, as what we have currently works, and I need to finish the other bits of the project.
JSON lines is a better format for this use case.
This allows whitespace in literals.
No idea if it actually works yet though.
jfrost-mo
force-pushed
the
MSc_ui_improvements
branch
from
06d6e99 to
47e766b
Compare
Path.copy and friends are only from python 3.14.
Member
Author
TODO for next year:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSET output interface improvements developed during my MSc project.
Additional work will be required before merging; see the "Future Work" chapter of my dissertation. This branch will also need a good rebase, as the commit history is a mess, and there were large test files added during development that have been removed, and we don't want to pull them into the project history permanently.
GitHub Copilot was used for a small part of this pull request, as detailed in the commit messages.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.