Merge develop into master #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add general map plotting method that reads plotting parameters from metadata - Add 'data generator' functionality. A method that creates derived data can be registered to a data store. When the derived data is accessed for the first time, the method will be called and the data stored. - Data stored as individual tensor components (f11, f12,...) stored as single tensor. Done for f, e, displacement, coordinate. - fix existing tests
- Fix inspector.py based on recent changes made to Map objects - Tidy inspector.py
- Use `skimage.draw.line` for getting pixel coordinates along a vector line (faster) - Remove pandas from `inspector.py` - Vectorise inner RDR calculation
- Improve formatting of tables in grain inspector
- Further improvements to `calcRDR` code in terms of perpendicular line generation reliability - Improve RDR panel layout
- Load EDX data from .crc into EBSD datastore [tested]
- Fix some issues in example_notebook as a result of change to dataStore - Fix `printStatsTable` and `plotMaxShear` so that it works with the new `datastore` (i.e. if component is tensor like `e` or `f` then print each element seperately)
Add project version specifier for `extras_require`
- A default component is now specified for each map data to plot is none is specified. - A component is either a tensor component or the name of an operation to apply to produce plotting data e.g. all Euler or IPF colours. - Any map data can now be plotted when picking homologous points. - Remove old methods for loading and plotting DIC pattern image
`setPatternPath` has changed to `set_pattern` etc
This is the earliest version that has out= in place of in_place=
Remove deprecated in_place arg to remove_small_objects
Load CSV files with 'pyvale-csv' and binary with 'pyvale-binary'
Add more non-001 orientations
Some function names were not changed
- Lots of repeated code from map class, needs refactoring when time - Remove `grain.plot_max_shear` and change all references
Instead of an arbitrary string, use 'None' to disable masking.
They previously overlapped a bit
Tidy and change uses of `grain.plot_map`
Improve masking
Fix labelling and position of HCP grains in IPF
mikesmic
approved these changes
Nov 5, 2025
Collaborator
mikesmic
left a comment
mikesmic
left a comment
There was a problem hiding this comment.
Oh boy, we changed a lot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something to work on in the next few weeks. Would be good to close out the remaining pull requests as as many issues as possible before we do this.