Skip to content

fix to avoid 1/0 problems #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alessandro-Barbieri wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix to avoid 1/0 problems #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea0d663
fix to avoid indetermination
Alessandro-Barbieri Aug 18, 2016
96b92eb
forgot pow
Alessandro-Barbieri Aug 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions skills/glicko.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,11 @@ def g(RD):
def E(r, rj, RDj):
return 1.0 / (1.0 + pow(10.0, -g(RDj) * (r - rj) / 400.0))

def d2(g_RD, E_sr_r_RD):
return pow(q ** 2.0 * sum(
def d2_inv(g_RD, E_sr_r_RD):
return (q ** 2.0 * sum(
g_RD[j] ** 2.0 * E_sr_r_RD[j] * (1.0 - E_sr_r_RD[j])
for j in range(len(g_RD))
), -1.0)
))

new_ratings = Match()
for player, rating in players.items():
Expand All @@ -164,7 +164,7 @@ def d2(g_RD, E_sr_r_RD):

# cache value, this form used twice in the paper
RD2_d2 = (1.0 / player_RD[player] ** 2.0 +
1.0 / d2(opponent_g_RD, opponent_E_sr_r_RD))
d2_inv(opponent_g_RD, opponent_E_sr_r_RD))

# new rating value
r_new = (rating.mean + q / RD2_d2 * sum(
Expand Down