vaultsSecretsEnv no longer cancels on missing secret
#918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tegefaulkes
approved these changes
Jul 8, 2025
Contributor
tegefaulkes
left a comment
tegefaulkes
left a comment
There was a problem hiding this comment.
Looks fine, nothing stands out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously,
vaultsSecretsEnvused to cancel the RPC if an error was encountered, disallowing any new secrets to be obtained. This PR will instead return errors as messages, so it is upto the client to parse the message instead of an error being thrown by the RPC.Issues Fixed
polykey secrets envPolykey-CLI#429Tasks
vaultsSecretsEnvcontinue on error/failureFinal checklist