Skip to content

Conversation

@erma07
Copy link

@erma07 erma07 commented Oct 3, 2023

This change adds prerelease constraint *-alpha.* for matching prerelease in a version with the following format 1.2.3-alpha.1

I am struggling to configure rancher fleet imageScans properly without this change.

@kmskebo
Copy link

kmskebo commented Mar 17, 2025

This is exactly what we need from Argo-CD and since Argo uses this library for version matching from semver. Is there anything that can be done to get this merged?

@danpf
Copy link

danpf commented Jun 30, 2025

Yes I'm having the same problem as @kmskebo - I'm willing to contribute if necessary!
we are using gitversion+gitflow versioning https://gitversion.net/docs/learn/branching-strategies/gitflow/examples so I'd like to get a build via: *-beta.* to match {major}.{minor}.{patch}-beta.{build#} and *-alpha.* to match {major}.{minor}.{patch}-alpha.{build#}

@yabberyabber
Copy link

We're in the same situation as kmskebo - needing some way to restrict based on prerelease.

@erma07 it looks like this PR branch is based on the v3.2.1 release, but v3.4.0 was recently released. I've rebased your changes locally and I see that the unit tests continue to pass after being rebased. I wonder if you rebasing this PR and then re-pushing it might make it easier for one of the semver repo maintainers to review the change when they find the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants