Even more tests to improve code coverage!

.golangci.yaml

@@ -2,21 +2,7 @@ version: "2"
 linters:
   enable:
     - gocritic
-  exclusions:
-    generated: lax
-    presets:
-      - comments
-      - common-false-positives
-      - legacy
-      - std-error-handling
-    paths:
-      - third_party$
-      - builtin$
-      - examples$
-formatters:
-  exclusions:
-    generated: lax
-    paths:
-      - third_party$
-      - builtin$
-      - examples$
+    - dupl
+  settings:
+    dupl:
+      threshold: 100

cmd/install.go

@@ -63,7 +63,8 @@ If you run "mtvm install go latest" it will install the latest version of go`,
 	Args:    cobra.ExactArgs(2),
 	Aliases: []string{"i", "in"},
 	Run: func(cmd *cobra.Command, args []string) {
-		err := createInstallDir(afero.NewOsFs())
+		fs := afero.NewOsFs()
+		err := createInstallDir(fs)
 		if err != nil {
 			log.Fatal(err)
 		}
@@ -79,7 +80,7 @@ If you run "mtvm install go latest" it will install the latest version of go`,
 				log.Fatal(err)
 			}
 		}
-		installed, err := shared.IsVersionInstalled(args[0], version)
+		installed, err := shared.IsVersionInstalled(args[0], version, fs)
 		if err != nil {
 			log.Fatal(err)
 		}

cmd/plugincmds/install.go

@@ -83,6 +83,15 @@ func getPluginInfoCmd(metadata plugin.Metadata) tea.Cmd {
 				url = v.Url
 			}
 		}
+		if url == "" {
+			return shared.NotFoundError{
+				Thing: "download",
+				Source: shared.Source{
+					File:     "cmd/plugincmds/install.go",
+					Function: "getPluginInfoCmd(metadata plugin.Metadata) tea.Cmd",
+				},
+			}
+		}
 		return pluginDownloadInfo{
 			Url:     url,
 			Name:    metadata.Name,

cmd/plugincmds/install_test.go

@@ -2,11 +2,13 @@ package plugincmds
 
 import (
 	"context"
-	"errors"
-	"fmt"
 	"runtime"
 	"testing"
 
+	"github.com/stretchr/testify/require"
+
+	"github.com/stretchr/testify/assert"
+
 	"github.com/MTVersionManager/mtvm/components/downloader"
 	"github.com/MTVersionManager/mtvm/plugin"
 	"github.com/MTVersionManager/mtvm/shared"
@@ -15,98 +17,118 @@ import (
 )
 
 func TestGetPluginInfo(t *testing.T) {
-	msg := getPluginInfoCmd(plugin.Metadata{
-		Name:    "loremIpsum",
-		Version: "0.0.0",
-		Downloads: []plugin.Download{
-			{
-				OS:   runtime.GOOS,
-				Arch: runtime.GOARCH,
-				Url:  "https://example.com",
-			},
+	type test struct {
+		metadata plugin.Metadata
+		testFunc func(t *testing.T, msg tea.Msg)
+	}
+	exampleUsableDownloads := []plugin.Download{
+		{
+			OS:   runtime.GOOS,
+			Arch: runtime.GOARCH,
+			Url:  "https://example.com",
 		},
-	})()
-	if downloadInfo, ok := msg.(pluginDownloadInfo); ok {
-		if downloadInfo.Name != "loremIpsum" {
-			t.Fatalf("want name to be 'loremIpsum', got name '%v'", downloadInfo.Name)
-		}
-		if downloadInfo.Url != "https://example.com" {
-			t.Fatalf("want url to be 'https://example.com', got url '%v'", downloadInfo.Url)
-		}
-		compareVersionTo := semver.New(0, 0, 0, "", "")
-		if !compareVersionTo.Equal(downloadInfo.Version) {
-			t.Fatalf("Want version 0.0.0 got %v", downloadInfo.Version.String())
-		}
-	} else if err, ok := msg.(error); ok {
-		t.Fatalf("want no error, got %v", err)
-	} else {
-		t.Fatalf("want pluginDownloadInfo returned, got %T with content %v", msg, msg)
 	}
-}
-
-func TestGetPluginInfoInvalidVersion(t *testing.T) {
-	msg := getPluginInfoCmd(plugin.Metadata{
-		Name:    "loremIpsum",
-		Version: "loremIpsum",
-		Downloads: []plugin.Download{
-			{
-				OS:   runtime.GOOS,
-				Arch: runtime.GOARCH,
-				Url:  "https://example.com",
+	tests := map[string]test{
+		"existing download": {
+			metadata: plugin.Metadata{
+				Name:      "loremIpsum",
+				Version:   "0.0.0",
+				Downloads: exampleUsableDownloads,
+			},
+			testFunc: func(t *testing.T, msg tea.Msg) {
+				if downloadInfo, ok := msg.(pluginDownloadInfo); ok {
+					assert.Equalf(t, "loremIpsum", downloadInfo.Name, "want name to be 'loremIpsum', got name '%v'", downloadInfo.Name)
+					assert.Equalf(t, "https://example.com", downloadInfo.Url, "want url to be 'https://example.com', got url '%v'", downloadInfo.Url)
+					compareVersionTo := semver.New(0, 0, 0, "", "")
+					if !compareVersionTo.Equal(downloadInfo.Version) {
+						t.Errorf("Want version 0.0.0 got %v", downloadInfo.Version.String())
+					}
+				} else if err, ok := msg.(error); ok {
+					assert.NoError(t, err)
+				} else {
+					t.Errorf("want pluginDownloadInfo returned, got %T with content %v", msg, msg)
+				}
+			},
+		},
+		"no download": {
+			metadata: plugin.Metadata{
+				Name:    "loremIpsum",
+				Version: "0.0.0",
+				Downloads: []plugin.Download{
+					{
+						OS: func() string {
+							if runtime.GOOS == "imaginaryOS" {
+								return "fakeOS"
+							}
+							return "imaginaryOS"
+						}(),
+						Arch: func() string {
+							if runtime.GOARCH == "imaginaryArch" {
+								return "fakeArch"
+							}
+							return "imaginaryArch"
+						}(),
+						Url: "https://example.com",
+					},
+				},
+			},
+			testFunc: func(t *testing.T, msg tea.Msg) {
+				if err, ok := msg.(error); ok {
+					shared.AssertIsNotFoundError(t, err, "download", shared.Source{
+						File:     "cmd/plugincmds/install.go",
+						Function: "getPluginInfoCmd(metadata plugin.Metadata) tea.Cmd",
+					})
+				} else {
+					t.Errorf("want error, got %T with content %v", msg, msg)
+				}
+			},
+		},
+		"invalid version": {
+			metadata: plugin.Metadata{
+				Name:      "loremIpsum",
+				Version:   "IAmAnInvalidVersion",
+				Downloads: exampleUsableDownloads,
+			},
+			testFunc: func(t *testing.T, msg tea.Msg) {
+				if err, ok := msg.(error); ok {
+					assert.ErrorIs(t, err, semver.ErrInvalidSemVer)
+				} else {
+					t.Errorf("want error, got %T with content %v", msg, msg)
+				}
 			},
 		},
-	})()
-	if err, ok := msg.(error); !ok {
-		t.Fatalf("want error, got %T with contents %v", msg, msg)
-	} else if !errors.Is(err, semver.ErrInvalidSemVer) {
-		t.Fatalf("want error containing ErrInvalidSemVer, got %v", err)
-	}
-}
-
-func TestInstallUpdateCancelQ(t *testing.T) {
-	err := CancelTest(tea.KeyMsg{
-		Type:  tea.KeyRunes,
-		Runes: []rune{'q'},
-	})
-	if err != nil {
-		t.Fatal(err)
-	}
-}
-
-func TestPluginInstallUpdateCancelCtrlC(t *testing.T) {
-	err := CancelTest(tea.KeyMsg{
-		Type: tea.KeyCtrlC,
-	})
-	if err != nil {
-		t.Fatal(err)
-	}
-}
-
-func CancelTest(keyPress tea.KeyMsg) error {
-	model := initialInstallModel("https://example.com")
-	_, cancel := context.WithCancel(context.Background())
-	modelUpdated, _ := model.Update(downloader.DownloadStartedMsg{
-		Cancel: cancel,
-	})
-	_, cmd := modelUpdated.Update(keyPress)
-	if cmd == nil {
-		return errors.New("want not nil command, got nil")
 	}
-	msg := cmd()
-	if _, ok := msg.(downloader.DownloadCanceledMsg); !ok {
-		return fmt.Errorf("expected returned command to return downloader.DownloadCanceledMsg, returned %v with type %T", msg, msg)
+	for name, tt := range tests {
+		t.Run(name, func(t *testing.T) {
+			t.Parallel()
+			msg := getPluginInfoCmd(tt.metadata)()
+			tt.testFunc(t, msg)
+		})
 	}
-	return nil
 }
 
-func TestPluginInstallUpdateEntriesSuccess(t *testing.T) {
-	model := initialInstallModel("https://example.com")
-	_, cmd := model.Update(shared.SuccessMsg("UpdateEntries"))
-	if cmd == nil {
-		t.Fatal("want not nil command, got nil")
+func TestInstallUpdateCancel(t *testing.T) {
+	tests := map[string]tea.KeyMsg{
+		"ctrl+c": {
+			Type: tea.KeyCtrlC,
+		},
+		"q": {
+			Type:  tea.KeyRunes,
+			Runes: []rune{'q'},
+		},
 	}
-	msg := cmd()
-	if _, ok := msg.(tea.QuitMsg); !ok {
-		t.Fatalf("want command to return tea.QuitMsg, returned %T with content %v", msg, msg)
+	for name, keyPress := range tests {
+		t.Run(name, func(t *testing.T) {
+			t.Parallel()
+			model := initialInstallModel("https://example.com")
+			_, cancel := context.WithCancel(context.Background())
+			modelUpdated, _ := model.Update(downloader.DownloadStartedMsg{
+				Cancel: cancel,
+			})
+			_, cmd := modelUpdated.Update(keyPress)
+			require.NotNil(t, cmd, "want not nil command, got nil")
+			msg := cmd()
+			assert.IsType(t, downloader.DownloadCanceledMsg{}, msg)
+		})
 	}
 }

cmd/remove.go

@@ -6,6 +6,8 @@ import (
 	"os"
 	"path/filepath"
 
+	"github.com/spf13/afero"
+
 	"github.com/MTVersionManager/mtvm/shared"
 	"github.com/MTVersionManager/mtvmplugin"
 	"github.com/charmbracelet/bubbles/spinner"
@@ -94,7 +96,8 @@ For example:
 				log.Fatal(err)
 			}
 		}
-		installed, err := shared.IsVersionInstalled(args[0], version)
+		fs := afero.NewOsFs()
+		installed, err := shared.IsVersionInstalled(args[0], version, fs)
 		if err != nil {
 			log.Fatal(err)
 		}

cmd/use.go

@@ -117,7 +117,7 @@ So if you run go version it will print the version number 1.23.3`,
 					log.Fatal(err)
 				}
 			}
-			versionInstalled, err := shared.IsVersionInstalled(args[0], version)
+			versionInstalled, err := shared.IsVersionInstalled(args[0], version, fs)
 			if err != nil {
 				log.Fatal(err)
 			}

components/downloader/downloader.go

@@ -43,8 +43,7 @@ func (dw *downloadWriter) Start() {
 	// This sends a signal to the update function that it is safe to close the response body
 	dw.copyDone <- true
 	if err != nil && !errors.Is(err, context.Canceled) {
-		fmt.Println("Error from copying")
-		log.Fatal(err)
+		log.Fatal(fmt.Errorf("from copying: %v", err))
 	}
 }
 
@@ -132,13 +131,18 @@ func (m Model) startDownload() tea.Msg {
 		return fmt.Errorf("%v %v", resp.StatusCode, http.StatusText(resp.StatusCode))
 	}
 	contentLengthKnown := true
-	if resp.ContentLength <= 0 {
-		if resp.ContentLength == -1 {
-			contentLengthKnown = false
-		} else {
-			cancel()
-			return errors.New("error when getting content length")
+	switch resp.ContentLength {
+	case -1:
+		contentLengthKnown = false
+	case 0:
+		cancel()
+		return errors.New("content length is 0")
+	default:
+		if resp.ContentLength > 0 {
+			break
 		}
+		cancel()
+		return errors.New("unexpected error when getting content length")
 	}
 	m.writer.totalSize = resp.ContentLength
 	m.writer.resp = resp