Validate tag values used in a search #2023
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a tag is invalid then we try and create a follow_tag url for it which fails due to failing the regex in the url. Avoid this by treating an invalid tag value as an error
alastair
force-pushed
the
follow-tag-url
branch
from
80382a7 to
68f97c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
Fixes #1987
Fixes https://logserver.mtg.upf.edu/organizations/sentry/issues/4720/?
Description
When we enter tags, they can only be a-zA-Z0-9 or hyphen. This is enforced in the sound edit form, and also in the follow tags url, but nowhere else.
If a browse query includes an invalid tag then we successfully search solr (no results), but then we try to generate a follow tags url, which fails. In the case of an invalid tag then just raise an error to the user.
todo
I'm not sure if we should show this error or treat that specific tag as invalid and remove it and continue the search. If we remove it then it might be a bit surprising to a user to see their entered tag not show up in results.