Feature/more colors #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schmluk
reviewed
Oct 22, 2025
Contributor
Schmluk
left a comment
Schmluk
left a comment
There was a problem hiding this comment.
Very cool! I actually recently had thought about exactly this 😄
| field(config.draw, "draw"); | ||
| field(config.scale, "scale"); | ||
| field(config.alpha, "alpha"); | ||
| enum_field(config.color, |
Contributor
There was a problem hiding this comment.
Minor: you could define a config utilities enum type conversion, then no duplicates would be needed.
nathanhhughes
added a commit
that referenced
this pull request
Oct 29, 2025
* add text color selection * also add edge color selection to visualizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Schmluk tagging for situational awareness in case you have other places where having some discrete color names that you can toggle between is more helpful than just an RGB value (may also try and clean up this next week a little)