Allocate ChunkSection::changed_blocks on demand
#219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Did this significantly impact |
Contributor
Author
|
I currently don't have the time to test this, but my prediction is that this will have no measurable impact on the performance of If someone decides to test this, the test should cover the case where there are no changed blocks and the case where there are changed blocks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a lot of memory being wasted on storing the
changed_blocksarray even when there are no changed blocks. This PR makes changes to allocate thechanged_blocksarray on-demand.Memory consumption when craftgpt is loaded (no players connected):