-
Notifications
You must be signed in to change notification settings - Fork 15
Update notebook to have ESA long-term token #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
View / edit / reply to this conversation on ReviewNB wildintellect commented on 2026-01-08T17:45:30Z @omshinde does it have to be in the same folder as the script/notebook? Can it not be at the root of the home for a user?
wildintellect commented on 2026-01-09T22:24:09Z make it clear where a user should save the file. |
|
View / edit / reply to this conversation on ReviewNB wildintellect commented on 2026-01-08T17:45:31Z I would use the user's home directory and do path expansion for the storage of the credential as noted above. |
|
Thanks @wildintellect. That's a valid point. I updated the ESA CCI notebook and the Earthcare notebook to reflect this. The ESA BIOMASS notebook will be changed in its respective PR. |
|
make it clear where a user should save the file. View entire conversation on ReviewNB |
|
View / edit / reply to this conversation on ReviewNB wildintellect commented on 2026-01-09T22:42:28Z remove stackstac, does not appear to be used |
|
View / edit / reply to this conversation on ReviewNB wildintellect commented on 2026-01-09T22:42:29Z Might be nice to overlay the tile boundaries, we did something similar in an older tutorial. https://docs.maap-project.org/en/latest/technical_tutorials/access/accessing_cod.html |
|
Overall the fix is ok, I'm not sure the text is clear where and how to save the token to a text file in their home directory. |
hrodmn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are using same ESA token credentials file approach in multiple tutorials (this one and the Biomass notebook) I think we need to consolidate the documentation and create a single guide to managing ESA credentials then reference it as a prerequisite to the science examples.
You could make the new ESA token notebook in this PR but I think it would be fine to merge this PR as-is and the Biomass example PR then handle the consolidation in a follow-up PR after the two ESA data access PRs are merged to the develop branch.
We could do better than a long-lived credentials.txt file. In the longer term (PI 26.2?) I think we should:
- update the Hub/ADE images to define the
ESA_CLIENT_SECRETandESA_CLIENT_IDconstants as environment variables - add a
maap-pyfunction that can be used to retrieve the access token
You're right that we should move this discussion to future planning. The downside of leveraging maap-py in that way, is that the code becomes less universal ... which might be ok if a MAAP account is required for ESA access. |
Fix https://github.com/NASA-IMPACT/active-maap-sprint/issues/1333