-
Notifications
You must be signed in to change notification settings - Fork 15
small edits to tutorials release #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Good to know.
It should be the person running the notebook. But that raises and interesting issue. I think hard coding the output directory to S3 as an algorithm variable is probably not a good idea. We probably need open a bug on the algorithm repo to fix that.
At this time no, I think we'll keep it as a user add-on, trying to balance default vs kitchen sink. Because of that maybe we need the |
|
Added conda install command at the top
How else would specifying the output directory be done? |
🤔 |
|
For the GEE notebook, maybe we could use the following code to get the username for environment setup? This came from another notebook
|
|
@smk0033 I agree and I just made the change! |
|
@grallewellyn since you're modifying the GEE with this PR can you also delist it from the Navigation as noted in #540 (comment) |
|
Done, do we want to add this disclaimer: "This notebook assumes that you have your GEE account setup. If not, refer here: [GEE docs]" If so, what is the link to the GEE docs? https://courses.spatialthoughts.com/gee-sign-up.html? |
|
I think the disclaimer would be great to have! I also found these docs: https://developers.google.com/earth-engine/guides/access |
Notable changes: