-
Notifications
You must be signed in to change notification settings - Fork 16
Remove dependency on Roboto font, and make all components font-agnostic. Enable consumers to have their desired font-family #2673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm…
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 😮 But that's a unicode. How would this happen? Does it mean that emojis won't show in the web-client neither?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure, but I think this is because that character technically isn't an emoji. I think that emojis are recognised by the system, and always rendered using the same font, but this icon is older than emojis, and therefore the selected font is left in charge of how its rendered. Or something like that anyway. You have the same with Char:
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (I'm not sure why the character changes between edit mode and read mode, since it looks like the same font is being used in both modes… 🤷♂️) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -77,4 +77,5 @@ | |
| .heading { | ||
| margin: 0; | ||
| font-size: 1rem; | ||
| font-weight: 600; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,6 @@ | |
|
|
||
| * { | ||
| box-sizing: border-box; | ||
| font-family: 'Roboto'; | ||
| } | ||
| } | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,7 +25,6 @@ | |
| color: rgb(var(--contrast-1100)); | ||
|
|
||
| font-size: 0.875rem; | ||
| font-family: 'Roboto'; | ||
| } | ||
|
|
||
| iframe { | ||
|
|
||



Uh oh!
There was an error while loading. Please reload this page.