Skip to content

Conversation

@kathyavini
Copy link
Collaborator

Description

Since I started with it, I just wanted to complete fixing this fade effect!

Jira link: https://lite-farm.atlassian.net/browse/LF-5096

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have ordered translation keys alphabetically (optional: run pnpm i18n to help with this)
  • I have added the GNU General Public License to all new files

@kathyavini kathyavini self-assigned this Dec 17, 2025
@kathyavini kathyavini requested review from a team as code owners December 17, 2025 19:01
@kathyavini kathyavini requested review from SayakaOno and removed request for a team December 17, 2025 19:01
@kathyavini kathyavini added the bug Something isn't working label Dec 17, 2025
@kathyavini kathyavini changed the title LF-5096 LF-5096 Consent checkbox focus border cut off by fade effect Dec 17, 2025
Copy link
Collaborator

@SayakaOno SayakaOno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🙌

@SayakaOno SayakaOno added this pull request to the merge queue Dec 18, 2025
Merged via the queue into integration with commit d75e4cd Dec 18, 2025
5 checks passed
@SayakaOno SayakaOno deleted the LF-5096-consent-checkbox-focus-border-cut-off-by-fade-effect branch December 18, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants