Skip to content

Conversation

@Ryszard-Trojnacki
Copy link

Description

I have make a simple change to webapp, that hides GoogleLoginButton if key in environment variable VITE_GOOGLE_OAUTH_CLIENT_ID is not provided (empty).

This change makes sense for self-hosting installation without Google OAuth.

Warning: Default value of VITE_GOOGLE_OAUTH_CLIENT_ID = ? is not interpreded as empty key. Question mark (?) needs to be removed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Installed on self-hosted server with VITE_GOOGLE_OAUTH_CLIENT_ID empty and non empty values.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@Ryszard-Trojnacki Ryszard-Trojnacki requested review from a team as code owners April 16, 2025 11:42
@Ryszard-Trojnacki Ryszard-Trojnacki requested review from Duncan-Brain and antsgar and removed request for a team April 16, 2025 11:42
@antsgar antsgar requested review from a team and kathyavini and removed request for a team and antsgar April 16, 2025 14:43
@Ryszard-Trojnacki Ryszard-Trojnacki force-pushed the feature/ILOT-61-hide-google-login branch from 9f2950e to 8130886 Compare September 16, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants