Hide GoogleLoginButton if no Google OAuth key provided. #3740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have make a simple change to webapp, that hides
GoogleLoginButtonif key in environment variableVITE_GOOGLE_OAUTH_CLIENT_IDis not provided (empty).This change makes sense for self-hosting installation without Google OAuth.
Warning: Default value of
VITE_GOOGLE_OAUTH_CLIENT_ID = ?is not interpreded as empty key. Question mark (?) needs to be removed.Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Installed on self-hosted server with
VITE_GOOGLE_OAUTH_CLIENT_IDempty and non empty values.Checklist: