Remove sc_convert_uaddr_to_host usage for address conversions in rawposix and 3i
#589
+10
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaxuan-w
reviewed
Jan 5, 2026
Member
Yaxuan-w
left a comment
Yaxuan-w
left a comment
There was a problem hiding this comment.
Changes make sense to me, but the CI tests failed.
Contributor
Author
|
The only case that was failing was All tests are passing now. |
Yaxuan-w
approved these changes
Jan 5, 2026
Member
Yaxuan-w
left a comment
Yaxuan-w
left a comment
There was a problem hiding this comment.
Looks good now! I'd suggest to change the title to explicitly mention that we're removing in both rawposix and 3i. Maybe sth like "Remove usage of sc_convert_uaddr_to_host in rawposix and 3i"?
stupendoussuperpowers
changed the title
sc_convert_uaddr_to_hostsc_convert_uaddr_to_host usage for address conversions in rawposix and 3i
Contributor
Author
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
futex_syscall,getrandom_syscall, andcopy_data_between_cagesstill use thesc_convert_uaddr_to_hostfunction, which is not necessary with the address translations changes. The use of this helper function has been removed from other functions that used them, this PR cleans up the remaining occurrences.