ci/cd: Fix lind script and docker file #572
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
End-to-End Test ReportTest PreviewTest Report Deterministic TestsSummary
Test Results by Category
Non Deterministic TestsSummary
Test Results by Category
Fail TestsSummary
Test Results by Category
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
J7-7-7
previously approved these changes
Dec 15, 2025
Yaxuan-w
changed the title
Contributor
End-to-End Test ReportTest PreviewTest Report Deterministic TestsSummary
Test Results by Category
Non Deterministic TestsSummary
Test Results by Category
Fail TestsSummary
Test Results by Category
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
rennergade
reviewed
Dec 16, 2025
| # Policy: | ||
| # - If user explicitly specifies a profile, honor it strictly. | ||
| # - Otherwise: | ||
| # * Use the only available profile if exactly one exists. |
Contributor
There was a problem hiding this comment.
I think this isn't a great way to go about this since we can easily be confused that were using one while actually using the other. Id rather there be some sort of warning/error if there's a mismatch and we fix the environments properly.
Member
Author
There was a problem hiding this comment.
I'm a bit confused. What do you mean by "fixing the environment"?
Contributor
There was a problem hiding this comment.
having the separate containers have the proper builds as defaults as well as not have dual version builds at once
Member
Author
There was a problem hiding this comment.
This script is not building same version at once, but for development needs. #572 (comment)
Contributor
There was a problem hiding this comment.
If PROFILE isn't expressed by an environment variable or a flag, we should make this fail and print a "NO PROFILE SET" error message instead of just picking one randomly. That way we don't run into bugs and have no idea whats happening.
If theres a problem in the CI stemming from that we have to set up the CI env properly in another PR.
Member
Author
There was a problem hiding this comment.
Profile is not an environment variable anymore. It's only an "option" determined by user input
Contributor
There was a problem hiding this comment.
Either way defaulting to "use the one that exists" is bad practice. Now that I've taken a second look I'm not sure removing the ENV variable is best practice, will probably make things harder to configure globally and is more of a bandaid then addressing the underlying issue.
Member
Author
There was a problem hiding this comment.
Profile is not used elsewhere previous
m-hemmings
previously approved these changes
Dec 16, 2025
Contributor
End-to-End Test ReportTest PreviewTest Report Deterministic TestsSummary
Test Results by Category
Non Deterministic TestsSummary
Test Results by Category
Fail TestsSummary
Test Results by Category
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the WASMTIME_PROFILE–related issue described in #560.
Previously, our development environment implicitly relied on
WASMTIME_PROFILEto decide which wasmtime binary to execute. In particular:WASMTIME_PROFILE=debug.As a result, both debug and release binaries could coexist, but
lind_runwould always execute the debug binary.This behavior masked issues locally and caused discrepancies between server-side development and CI, which runs in a clean environment.
This PR makes two related changes to eliminate the ambiguity:
In Dockerfile.dev:
In lind_run script:
--wasmtime-profile={release|debug}.In lind_compile script: