Skip to content

Prefer File constructor argument to String argument #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-jeckels merged 3 commits into from
Oct 22, 2025
Merged

Prefer File constructor argument to String argument #1203

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
885721f
More file path improvements, mostly around pipeline jobs
labkey-jeckels Oct 18, 2025
3d36dcf
Merge branch 'develop' into fb_pipelineFileLike
labkey-jeckels Oct 20, 2025
9ed04f1
Merge branch 'develop' into fb_pipelineFileLike
labkey-jeckels Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/bootstrap/src/org/labkey/bootstrap/LabKeyBootstrapClassLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ public void validateReplaceArchive(File explodedModuleDirectory, File updatedArc
@Override
public Map.Entry<File,File> updateModule(File explodedModuleDirectory, File updateArchive, File existingArchive, File mvExistingArchive, boolean dryRun) throws IOException
{
File updateArchiveNewHome = new File(existingArchive.getParent(), updateArchive.getName());
File updateArchiveNewHome = new File(existingArchive.getParentFile(), updateArchive.getName());

validateReplaceArchive(explodedModuleDirectory, updateArchive, existingArchive);

Expand Down