-
Notifications
You must be signed in to change notification settings - Fork 3
Remove extra logging, add additional task for removing npm versions and remove use of versioning plugin #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
labkey-tchad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this doesn't work on Windows, maybe we could use the JGit library used by our VCS license tool? https://github.com/LabKey/tools/blob/develop/vcslicense/src/org/labkey/vcslicense/VCSLicense.java
Good thought to keep in mind. Fortunately, indications are that it does work on Windows as currently written. |
| ### TBD | ||
| ### 7.X.X | ||
| *Released*: TBD | ||
| (Earliest compatible LabKey version: 25.10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
25.12?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should still be compatible with 25.10 since the presence of the versioning plugin version shouldn't cause problems; we simply won't be using it.
Rationale
module.xmlfile without the (dying) versioning pluginRelated Pull Requests
Changes
PurgeNpmVersionstask